Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explorer] Add "add data" application navigation button #165486

Closed
weltenwort opened this issue Sep 1, 2023 · 1 comment · Fixed by #166266
Closed

[Explorer] Add "add data" application navigation button #165486

weltenwort opened this issue Sep 1, 2023 · 1 comment · Fixed by #166266
Assignees
@tonyghiani
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

📓 Summary

In addition to the fall-back link to Discover we want to have an "Add data" button in the application navigation bar.

✔️ Acceptance criteria

  • There is an "Add data" button in the application navigation bar, which navigates to the new observability onboarding overview page.

🎨 Mock-ups

Image

💡 Implementation hints
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 1, 2023
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 1, 2023
@tonyghiani tonyghiani self-assigned this Sep 5, 2023
@tonyghiani tonyghiani mentioned this issue Sep 6, 2023
Merged
tonyghiani added a commit that referenced this issue Sep 6, 2023
@tonyghiani @kibanamachine @yngrdyn
[Logs Onboarding] Implement Observability Onboarding locator (#165805)
8c39735 
## 📓 Summary

In preparation for #165486 where we'll implement a call to action to
bring into the logs onboarding, this PR implement the onboarding locator
for the `observability_onboarding` plugin.

The locator is both returned in the plugin contract and registered in
the central registry so that we'll be able to consume it without
creating circular dependencies between `observability_onboarding` and
`observability_log_explorer` plugins.

With this first iteration, the locator allows to navigate to the landing
page or to specify a log source to onboard:
```ts
// Navigate to onboarding landing page: /app/observabilityOnboarding
plugins.share.url.locators.get(OBSERVABILITY_ONBOARDING_LOCATOR).navigate()

// Navigate to system logs onboarding: /app/observabilityOnboarding/systemLogs
plugins.share.url.locators.get(OBSERVABILITY_ONBOARDING_LOCATOR).navigate({source: 'systemLogs'})


// Navigate to custom logs onboarding: /app/observabilityOnboarding/customLogs
plugins.share.url.locators.get(OBSERVABILITY_ONBOARDING_LOCATOR).navigate({source: 'customLogs'})
```

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
@formgeist formgeist changed the title [Log Explorer] Add "add data" application navigation button [Explorer] Add "add data" application navigation button Sep 6, 2023
@tonyghiani tonyghiani mentioned this issue Sep 12, 2023
Merged
tonyghiani added a commit that referenced this issue Sep 14, 2023
@tonyghiani @kibanamachine
[Log Explorer] Add "Add data" button (#166266)
39cf371 
## 📓 Summary

Closes #165486 

This work restructured the entry point for the 2 different header menus
(stateful, serverless) and added both of them the Add data button to
navigate to the onboarding page.

**Stateful**

<img width="1780" alt="Screenshot 2023-09-12 at 16 01 16"
src="https://github.com/elastic/kibana/assets/34506779/535a9a5c-603e-4c35-976a-70421c5e36d8">

**Serverless**

<img width="1783" alt="Screenshot 2023-09-12 at 15 49 09"
src="https://github.com/elastic/kibana/assets/34506779/aaa57f41-c4d8-4da1-a808-8b55954df716">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs Explorer] Add "Add data" button tonyghiani/kibana
4 participants
@weltenwort @gbamparop @elasticmachine @tonyghiani