Skip to content

Commit

Permalink
[8.x] fix: [Stateful: Indices Overview page] Inaccurate announcement …
Browse files Browse the repository at this point in the history
…for programming language buttons (#197428) (#199011)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Stateful: Indices Overview page] Inaccurate announcement for
programming language buttons
(#197428)](#197428)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T15:38:44Z","message":"fix:
[Stateful: Indices Overview page] Inaccurate announcement for
programming language buttons (#197428)\n\nCloses: #196282\r\n\r\n##
Summary\r\n\r\nButton elements should be clear and understandable to
users, including\r\nthose using assistive technologies. `h5` tag looks
unnatural inside a\r\nbutton.\r\n\r\n## What was changed?: \r\n\r\n1.
`h5` -> `strong`\r\n\r\n## Screen: \r\n\r\n<img width=\"1190\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ea02864f-4091-4cc9-a674-ebf1f4ee7499\">","sha":"7f97c8074f7d6c2adf4a7a35fa7ac96b25f6cfe4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Stateful: Indices Overview page] Inaccurate announcement for
programming language
buttons","number":197428,"url":"https://github.com/elastic/kibana/pull/197428","mergeCommit":{"message":"fix:
[Stateful: Indices Overview page] Inaccurate announcement for
programming language buttons (#197428)\n\nCloses: #196282\r\n\r\n##
Summary\r\n\r\nButton elements should be clear and understandable to
users, including\r\nthose using assistive technologies. `h5` tag looks
unnatural inside a\r\nbutton.\r\n\r\n## What was changed?: \r\n\r\n1.
`h5` -> `strong`\r\n\r\n## Screen: \r\n\r\n<img width=\"1190\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ea02864f-4091-4cc9-a674-ebf1f4ee7499\">","sha":"7f97c8074f7d6c2adf4a7a35fa7ac96b25f6cfe4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197428","number":197428,"mergeCommit":{"message":"fix:
[Stateful: Indices Overview page] Inaccurate announcement for
programming language buttons (#197428)\n\nCloses: #196282\r\n\r\n##
Summary\r\n\r\nButton elements should be clear and understandable to
users, including\r\nthose using assistive technologies. `h5` tag looks
unnatural inside a\r\nbutton.\r\n\r\n## What was changed?: \r\n\r\n1.
`h5` -> `strong`\r\n\r\n## Screen: \r\n\r\n<img width=\"1190\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ea02864f-4091-4cc9-a674-ebf1f4ee7499\">","sha":"7f97c8074f7d6c2adf4a7a35fa7ac96b25f6cfe4"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
  • Loading branch information
kibanamachine and alexwizp authored Nov 5, 2024
1 parent 8ff526e commit f96bec2
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,12 @@ export const LanguageClientPanel: React.FC<SelectClientProps> = ({
width={euiTheme.size.xl}
/>
<EuiSpacer size="s" />
<EuiText textAlign="center" color={isSelectedLanguage ? 'default' : 'subdued'}>
<h5>{language.name}</h5>
<EuiText
size="relative"
textAlign="center"
color={isSelectedLanguage ? 'default' : 'subdued'}
>
<strong>{language.name}</strong>
</EuiText>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down

0 comments on commit f96bec2

Please sign in to comment.