Skip to content

Commit

Permalink
[Sustainable Kibana Architecture] Update plugins (wave #1) (#195375)
Browse files Browse the repository at this point in the history
## Summary

Follow-up of #195367
As part of the Sustainable Kibana Architecture initiative, this PR
leverages the mechanisms and concepts introduced in
#194810, updating plugins that
were considered to be solution-specific in Luke's
[PoC](#179710).

This might trigger linting rule violations in CI, and help uncover
conflicts related to forbidden dependencies.
As soon as they are resolved, we can proceed to classify solutions'
plugins.

(cherry picked from commit a5517d9)

# Conflicts:
#	src/plugins/maps_ems/kibana.jsonc
#	x-pack/plugins/file_upload/kibana.jsonc
#	x-pack/plugins/maps/kibana.jsonc
  • Loading branch information
gsoldevila committed Nov 7, 2024
1 parent 37e030a commit e634471
Show file tree
Hide file tree
Showing 185 changed files with 1,765 additions and 691 deletions.
48 changes: 48 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -1978,6 +1978,54 @@ module.exports = {
'max-classes-per-file': 'off',
},
},
{
files: [
'packages/kbn-reporting/common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/export_types/pdf_common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/export_types/pdf/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/export_types/png_common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/export_types/png/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/public/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/kbn-reporting/server/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
'packages/shared-ux/page/analytics_no_data/types/**',
'scripts/create_observability_rules.js', // TODO - is importing "@kbn/observability-alerting-test-data" (observability/private)
'src/cli_setup/**', // TODO @kibana/operations - is importing "@kbn/interactive-setup-plugin" (platform/private)
'src/dev/build/tasks/install_chromium.ts', // TODO @kibana/operations - is importing "@kbn/screenshotting-plugin" (platform/private)
'src/plugins/ai_assistant_management/selection/**',
'src/plugins/dashboard/**',
'src/plugins/discover/**',
'test/**',
'x-pack/examples/exploratory_view_example/**',
'x-pack/examples/screenshotting_example/**',
'x-pack/examples/ui_actions_enhanced_examples/**',
'x-pack/packages/security-solution/data_table/**',
'x-pack/plugins/aiops/**',
'x-pack/plugins/data_quality/**',
'x-pack/plugins/ingest_pipelines/**',
'x-pack/plugins/ml/**',
'x-pack/plugins/monitoring/**',
'x-pack/plugins/observability_solution/infra/**',
'x-pack/plugins/observability_solution/inventory/**',
'x-pack/plugins/observability_solution/investigate_app/**',
'x-pack/plugins/observability_solution/investigate/**',
'x-pack/plugins/observability_solution/logs_shared/**',
'x-pack/plugins/observability_solution/metrics_data_access/**',
'x-pack/plugins/observability_solution/observability_ai_assistant_app/**',
'x-pack/plugins/observability_solution/observability_ai_assistant_management/**',
'x-pack/plugins/observability_solution/observability/**',
'x-pack/plugins/observability_solution/slo/**',
'x-pack/plugins/observability_solution/synthetics/e2e/**',
'x-pack/plugins/osquery/**',
'x-pack/plugins/search_assistant/**',
'x-pack/test_serverless/**',
'x-pack/test/**',
'x-pack/test/plugin_functional/plugins/resolver_test/**',
],
rules: {
'@kbn/imports/no_group_crossing_manifests': 'warn',
'@kbn/imports/no_group_crossing_imports': 'warn',
},
},
],
};

Expand Down
14 changes: 9 additions & 5 deletions src/plugins/advanced_settings/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
{
"type": "plugin",
"id": "@kbn/advanced-settings-plugin",
"owner": "@elastic/appex-sharedux @elastic/kibana-management",
"owner": [
"@elastic/appex-sharedux",
"@elastic/kibana-management"
],
"group": "platform",
"visibility": "private",
"plugin": {
"id": "advancedSettings",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"management"
],
"optionalPlugins": [
"home",
"usageCollection"
],
"requiredBundles": [
]
"requiredBundles": []
}
}
}
26 changes: 19 additions & 7 deletions src/plugins/ai_assistant_management/selection/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,16 +1,28 @@
{
"type": "plugin",
"id": "@kbn/ai-assistant-management-plugin",
"owner": "@elastic/obs-knowledge-team",
"owner": [
"@elastic/obs-knowledge-team"
],
"group": "platform",
"visibility": "private",
"plugin": {
"id": "aiAssistantManagementSelection",
"server": true,
"browser": true,
"requiredPlugins": ["management"],
"optionalPlugins": ["home", "serverless", "features"],
"requiredBundles": ["kibanaReact"],
"server": true,
"configPath": [
"aiAssistantManagementSelection"
],
},
}
"requiredPlugins": [
"management"
],
"optionalPlugins": [
"home",
"serverless",
"features"
],
"requiredBundles": [
"kibanaReact"
]
}
}
10 changes: 7 additions & 3 deletions src/plugins/bfetch/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
{
"type": "plugin",
"id": "@kbn/bfetch-plugin",
"owner": "@elastic/appex-sharedux",
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared",
"description": "Considering using bfetch capabilities when fetching large amounts of data. This services supports batching HTTP requests and streaming responses back.",
"plugin": {
"id": "bfetch",
"server": true,
"browser": true,
"server": true,
"requiredBundles": [
"kibanaUtils"
]
}
}
}
8 changes: 6 additions & 2 deletions src/plugins/chart_expressions/common/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-common",
"id": "@kbn/chart-expressions-common",
"owner": "@elastic/kibana-visualizations"
}
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared"
}
10 changes: 7 additions & 3 deletions src/plugins/chart_expressions/expression_gauge/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-gauge-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Expression Gauge plugin adds a `gauge` renderer and function to the expression plugin. The renderer will display the `gauge` chart.",
"plugin": {
"id": "expressionGauge",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"fieldFormats",
Expand All @@ -25,4 +29,4 @@
"common"
]
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/chart_expressions/expression_heatmap/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-heatmap-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Expression Heatmap plugin adds a `heatmap` renderer and function to the expression plugin. The renderer will display the `heatmap` chart.",
"plugin": {
"id": "expressionHeatmap",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"fieldFormats",
Expand All @@ -25,4 +29,4 @@
"common"
]
}
}
}
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-legacy-metric-vis-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `legacy metric` chart.",
"plugin": {
"id": "expressionLegacyMetricVis",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"fieldFormats",
Expand All @@ -22,4 +26,4 @@
"kibanaUtils"
]
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/chart_expressions/expression_metric/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-metric-vis-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `metric` chart.",
"plugin": {
"id": "expressionMetricVis",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"fieldFormats",
Expand All @@ -22,4 +26,4 @@
"kibanaUtils"
]
}
}
}
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-partition-vis-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Expression Partition Visualization plugin adds a `partitionVis` renderer and `pieVis`, `mosaicVis`, `treemapVis`, `waffleVis` functions to the expression plugin. The renderer will display the `pie`, `waffle`, `treemap` and `mosaic` charts.",
"plugin": {
"id": "expressionPartitionVis",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"charts",
"data",
Expand All @@ -25,4 +29,4 @@
"common"
]
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/chart_expressions/expression_tagcloud/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-tagcloud-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Expression Tagcloud plugin adds a `tagcloud` renderer and function to the expression plugin. The renderer will display the `Wordcloud` chart.",
"plugin": {
"id": "expressionTagcloud",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"data",
"expressions",
Expand All @@ -25,4 +29,4 @@
"common"
]
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/chart_expressions/expression_xy/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"type": "plugin",
"id": "@kbn/expression-xy-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"description": "Expression XY plugin adds a `xy` renderer and function to the expression plugin. The renderer will display the `xy` chart.",
"plugin": {
"id": "expressionXY",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"charts",
Expand All @@ -21,4 +25,4 @@
],
"requiredBundles": []
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/charts/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
{
"type": "plugin",
"id": "@kbn/charts-plugin",
"owner": "@elastic/kibana-visualizations",
"owner": [
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "shared",
"plugin": {
"id": "charts",
"server": true,
"browser": true,
"server": true,
"requiredPlugins": [
"expressions",
"data"
Expand All @@ -14,4 +18,4 @@
"common"
]
}
}
}
10 changes: 7 additions & 3 deletions src/plugins/console/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
{
"type": "plugin",
"id": "@kbn/console-plugin",
"owner": "@elastic/kibana-management",
"owner": [
"@elastic/kibana-management"
],
"group": "platform",
"visibility": "shared",
"plugin": {
"id": "console",
"server": true,
"browser": true,
"server": true,
"configPath": [
"console"
],
Expand All @@ -23,4 +27,4 @@
"kibanaUtils"
]
}
}
}
Loading

0 comments on commit e634471

Please sign in to comment.