[8.x] Allow empty spaces un Gsub processor (#197815) (#199293)

# Backport This will backport the following commits from `main` to `8.x`: - [Allow empty spaces un Gsub processor (#197815)](#197815)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Sonia Sanz Vivas <[email protected]>
elastic · Nov 7, 2024 · 37e030a · 37e030a
1 parent ed448dd
commit 37e030a
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 4 deletions.
diff --git a/src/plugins/es_ui_shared/static/forms/helpers/field_validators/empty_field.test.ts b/src/plugins/es_ui_shared/static/forms/helpers/field_validators/empty_field.test.ts
@@ -0,0 +1,48 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+import { ValidationFuncArg } from '../../hook_form_lib';
+import { emptyField } from './empty_field';
+
+describe('emptyField', () => {
+  const message = 'test error message';
+  const code = 'ERR_FIELD_MISSING';
+  const path = 'path';
+
+  const validator = (value: string | any[], trimString?: boolean) =>
+    emptyField(message, trimString)({ value, path } as ValidationFuncArg<any, any>);
+
+  test('should return Validation function if value is an empty string and trimString is true', () => {
+    expect(validator('')).toMatchObject({ message, code, path });
+  });
+
+  test('should return Validation function if value is an empty string and trimString is false', () => {
+    expect(validator('', false)).toMatchObject({ message, code, path });
+  });
+
+  test('should return Validation function if value is a space and trimString is true', () => {
+    expect(validator(' ')).toMatchObject({ message, code, path });
+  });
+
+  test('should return undefined if value is a space and trimString is false', () => {
+    expect(validator(' ', false)).toBeUndefined();
+  });
+
+  test('should return undefined if value is a string and is not empty', () => {
+    expect(validator('not Empty')).toBeUndefined();
+  });
+
+  test('should return undefined if value an array and is not empty', () => {
+    expect(validator(['not Empty'])).toBeUndefined();
+  });
+
+  test('should return undefined if value an array and is empty', () => {
+    expect(validator([])).toMatchObject({ message, code, path });
+  });
+});
diff --git a/src/plugins/es_ui_shared/static/forms/helpers/field_validators/empty_field.ts b/src/plugins/es_ui_shared/static/forms/helpers/field_validators/empty_field.ts
@@ -13,12 +13,14 @@ import { isEmptyArray } from '../../../validators/array';
 import { ERROR_CODE } from './types';
 
 export const emptyField =
-  (message: string) =>
+  (message: string, trimString: boolean = true) =>
   (...args: Parameters<ValidationFunc>): ReturnType<ValidationFunc<any, ERROR_CODE>> => {
     const [{ value, path }] = args;
 
     if (typeof value === 'string') {
-      return isEmptyString(value) ? { code: 'ERR_FIELD_MISSING', path, message } : undefined;
+      return isEmptyString(value, trimString)
+        ? { code: 'ERR_FIELD_MISSING', path, message }
+        : undefined;
     }
 
     if (Array.isArray(value)) {

diff --git a/src/plugins/es_ui_shared/static/validators/string/is_empty.ts b/src/plugins/es_ui_shared/static/validators/string/is_empty.ts
@@ -7,4 +7,5 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export const isEmptyString = (value: string) => value.trim() === '';
+export const isEmptyString = (value: string, trimString: boolean = true) =>
+  (trimString ? value.trim() : value) === '';
diff --git a/...blic/application/components/pipeline_editor/components/processor_form/processors/gsub.tsx b/...blic/application/components/pipeline_editor/components/processor_form/processors/gsub.tsx
@@ -37,7 +37,8 @@ const fieldsConfig: FieldsConfig = {
         validator: emptyField(
           i18n.translate('xpack.ingestPipelines.pipelineEditor.gsubForm.patternRequiredError', {
             defaultMessage: 'A value is required.',
-          })
+          }),
+          false
         ),
       },
       {
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,7 +37,8 @@ const fieldsConfig: FieldsConfig = { @@
             validator: emptyField(
               i18n.translate('xpack.ingestPipelines.pipelineEditor.gsubForm.patternRequiredError', {
                 defaultMessage: 'A value is required.',
-              })
+              }),
+              false
             ),
           },
           {
@@ Expand Down @@