Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async_search query parameter validation #3167

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

pquentin
Copy link
Member

I submitted the rest-api-spec changes to elastic/elasticsearch#117312.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.status 🟢 3/3 3/3
async_search.submit 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.status 🟢 3/3 3/3
async_search.submit 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit db7943e into main Nov 26, 2024
8 checks passed
@pquentin pquentin deleted the async-search-query-parameters branch November 26, 2024 13:55
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3167-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db7943eb40399d122e30242961c335428d81ab20
# Push it to GitHub
git push --set-upstream origin backport-3167-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3167-to-8.x.

Copy link
Contributor

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3167-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db7943eb40399d122e30242961c335428d81ab20
# Push it to GitHub
git push --set-upstream origin backport-3167-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3167-to-8.16.

Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3167-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db7943eb40399d122e30242961c335428d81ab20
# Push it to GitHub
git push --set-upstream origin backport-3167-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3167-to-8.17.

pquentin added a commit that referenced this pull request Nov 27, 2024
(cherry picked from commit db7943e)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Nov 27, 2024
(cherry picked from commit db7943e)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.16

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Nov 27, 2024
(cherry picked from commit db7943e)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants