Skip to content

Commit

Permalink
Fix async_search query parameter validation (#3167)
Browse files Browse the repository at this point in the history
(cherry picked from commit db7943e)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
  • Loading branch information
pquentin committed Nov 27, 2024
1 parent 8ec9a19 commit af1cef4
Show file tree
Hide file tree
Showing 8 changed files with 67 additions and 68 deletions.
25 changes: 10 additions & 15 deletions output/openapi/elasticsearch-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 10 additions & 15 deletions output/openapi/elasticsearch-serverless-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 17 additions & 14 deletions output/schema/schema-serverless.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 17 additions & 14 deletions output/schema/schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions output/schema/validation-errors.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion output/typescript/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions specification/async_search/status/AsyncSearchStatusRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import { RequestBase } from '@_types/Base'
import { Id } from '@_types/common'
import { Duration } from '@_types/Time'

/**
* Get the async search status.
Expand All @@ -36,4 +37,12 @@ export interface Request extends RequestBase {
/** A unique identifier for the async search. */
id: Id
}
query_parameters: {
/**
* Specifies how long the async search needs to be available.
* Ongoing async searches and any saved search results are deleted after this period.
* @server_default 5d
*/
keep_alive?: Duration
}
}
5 changes: 3 additions & 2 deletions specification/async_search/submit/AsyncSearchSubmitRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ import { Duration } from '@_types/Time'
* @doc_id async-search
* @doc_tag search
*/
// NOTE: this is a SearchRequest with 3 added parameters: wait_for_completion_timeout, keep_on_completion and keep_alive
// NOTE: this is a SearchRequest with:
// * 3 added parameters: wait_for_completion_timeout, keep_on_completion and keep_alive
// * 1 removed parameters: scroll
export interface Request extends RequestBase {
path_parts: {
index?: Indices
Expand Down Expand Up @@ -124,7 +126,6 @@ export interface Request extends RequestBase {
/** @server_default true */
request_cache?: boolean
routing?: Routing
scroll?: Duration
search_type?: SearchType
stats?: string[]
stored_fields?: Fields
Expand Down

0 comments on commit af1cef4

Please sign in to comment.