Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include type in Significant Text agg #2279

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix include type in Significant Text agg #2279

merged 2 commits into from
Sep 20, 2023

Conversation

pquentin
Copy link
Member

Closes #2275

I'm not sure where this should be backported exactly. This aggregation was introduced in Elasticsearch 6.0.

@pquentin pquentin requested a review from a team September 19, 2023 07:25
@JoshMock
Copy link
Member

I'm not sure where this should be backported exactly. This aggregation was introduced in Elasticsearch 6.0.

Since we're not likely to release any minor/patch versions older than 8.8, we could probably just backport to 8.8, 8.9 and 8.10 for now. For other versions we can probably address on a case-by-case basis so you don't have to open 20 backport PRs. 😆

@pquentin pquentin merged commit ca591c5 into main Sep 20, 2023
5 checks passed
@pquentin pquentin deleted the issue-2275 branch September 20, 2023 06:27
@github-actions
Copy link
Contributor

The backport to 8.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.9 8.9
# Navigate to the new working tree
cd .worktrees/backport-8.9
# Create a new branch
git switch --create backport-2279-to-8.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 ca591c5eda691a76bb5456d29637493b9a25b426
# Push it to GitHub
git push --set-upstream origin backport-2279-to-8.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.9

Then, create a pull request where the base branch is 8.9 and the compare/head branch is backport-2279-to-8.9.

@github-actions
Copy link
Contributor

The backport to 8.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.8 8.8
# Navigate to the new working tree
cd .worktrees/backport-8.8
# Create a new branch
git switch --create backport-2279-to-8.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 ca591c5eda691a76bb5456d29637493b9a25b426
# Push it to GitHub
git push --set-upstream origin backport-2279-to-8.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.8

Then, create a pull request where the base branch is 8.8 and the compare/head branch is backport-2279-to-8.8.

@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2279-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 ca591c5eda691a76bb5456d29637493b9a25b426
# Push it to GitHub
git push --set-upstream origin backport-2279-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2279-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant Text aggregation missing regex include method
2 participants