-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix include/exclude type in Frequent Items agg #2280
Conversation
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.8 8.8
# Navigate to the new working tree
cd .worktrees/backport-8.8
# Create a new branch
git switch --create backport-2280-to-8.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 fa57bcdbb1823eb2b62ee983f64f131f4b2fc02e
# Push it to GitHub
git push --set-upstream origin backport-2280-to-8.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.8 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.7 8.7
# Navigate to the new working tree
cd .worktrees/backport-8.7
# Create a new branch
git switch --create backport-2280-to-8.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 fa57bcdbb1823eb2b62ee983f64f131f4b2fc02e
# Push it to GitHub
git push --set-upstream origin backport-2280-to-8.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.7 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.9 8.9
# Navigate to the new working tree
cd .worktrees/backport-8.9
# Create a new branch
git switch --create backport-2280-to-8.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 fa57bcdbb1823eb2b62ee983f64f131f4b2fc02e
# Push it to GitHub
git push --set-upstream origin backport-2280-to-8.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.9 Then, create a pull request where the |
Co-authored-by: Quentin Pradet <[email protected]>
Backports:
|
When working on #2279, I noticed that the Frequent Items set aggregation appears to reuse the standard include/exclude support, so I fixed it too.
I opened a different pull request because this aggregation is much more recent: it went GA for Elasticsearch 8.7. I would also appreciate guidance regarding the backports labels.