-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant/deprecated np.float_
use to fix NumPy 2.0 compat
#2551
Conversation
Remove the explicit use of `np.float_` type that is an alias to `np.float64` and that has been removed in NumPy 2.0. This fixes a hard error when running on this version on NumPy, while preserving compatibility with NumPy 1. Fixes elastic#2550
💚 CLA has been signed |
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Signed. |
buildkite test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mgorny! LGTM.
Thanks! |
Remove the explicit use of
np.float_
type that is an alias tonp.float64
and that has been removed in NumPy 2.0. This fixes a hard error when running on this version on NumPy, while preserving compatibility with NumPy 1.Fixes #2550