Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant/deprecated np.float_ use to fix NumPy 2.0 compat #2551

Merged
merged 1 commit into from
May 4, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 4, 2024

Remove the explicit use of np.float_ type that is an alias to np.float64 and that has been removed in NumPy 2.0. This fixes a hard error when running on this version on NumPy, while preserving compatibility with NumPy 1.

Fixes #2550

Remove the explicit use of `np.float_` type that is an alias to
`np.float64` and that has been removed in NumPy 2.0.  This fixes a hard
error when running on this version on NumPy, while preserving
compatibility with NumPy 1.

Fixes elastic#2550
Copy link

cla-checker-service bot commented May 4, 2024

💚 CLA has been signed

Copy link

github-actions bot commented May 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mgorny
Copy link
Contributor Author

mgorny commented May 4, 2024

❌ Author of the following commits did not sign a Contributor Agreement: 7cdc582

Please, read and sign the above mentioned agreement if you want to contribute to this project

Signed.

@pquentin
Copy link
Member

pquentin commented May 4, 2024

buildkite test this please

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgorny! LGTM.

@pquentin pquentin merged commit aed94d2 into elastic:main May 4, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request May 4, 2024
@mgorny
Copy link
Contributor Author

mgorny commented May 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures against NumPy 2.0.0rc1
2 participants