Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency]: Numpy 2.X #2646

Closed
alvarogf97 opened this issue Aug 27, 2024 · 3 comments
Closed

[Dependency]: Numpy 2.X #2646

alvarogf97 opened this issue Aug 27, 2024 · 3 comments

Comments

@alvarogf97
Copy link

Description

numpy.float_ has been deprecated in favor of numpy.float64 because after the update numpy always maintain float precision. This package uses numpy only when JsonSerializer is used and declare np.float_ in version 7.X here

Version

elasticsearch : 7.17

Proposal

Update basecode as defined in the 8.X version but for 7.X, if an update is not posible for 7.X package version, blocking numpy dependency to <2.X would be enough to avoid incompatibilites.

Please let me know if a PR is required and I will prepare it!

Thanks in advance

@pquentin
Copy link
Member

Not sure why you closed this.

Feel free to backport #2551 to the 7.17 branch! I can't promise a release soon though.

@alvarogf97
Copy link
Author

alvarogf97 commented Aug 27, 2024

Not sure why you closed this.

Feel free to backport #2551 to the 7.17 branch! I can't promise a release soon though.

Hey,

Even though version 7.17 was in the file, the lockfile had not been updated. It may look that test are ok but if you need to use JsonSerialize it does not work with the new version so I will reopened It.

I will make a PR as soon as possible, thanks for your work

@pquentin
Copy link
Member

Closing as I released a 7.x version with the fix. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants