Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use .java-version and prepare to use VM with installed tools in BK #241

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 7, 2024

What does this PR do?

  • Enable .java-version - that contains the current major java version
  • Enable dry-run in the release/snapshot by default.
  • Fallback to install java in Buildkite if the JAVA_HOME is not in the Buildkite runner - a follow-up to use a VM with the installed tools

Why

  • Stability and reliability.
  • Faster builds.

Follow-up

  • Use the VMs with the tools in Buildkite

Test

Triggering manually against this particular feature branch (for such, I use the snapshot one):

  • Snapshot build in Buildkite
  • Release build in Buildkite

@v1v v1v requested review from a team March 7, 2024 21:59
@v1v v1v self-assigned this Mar 7, 2024
.ci/snapshot.sh Outdated Show resolved Hide resolved
.ci/snapshot.sh Outdated Show resolved Hide resolved
.ci/release.sh Outdated Show resolved Hide resolved
amannocci
amannocci previously approved these changes Mar 8, 2024
@v1v v1v requested review from SylvainJuge and amannocci March 8, 2024 12:47
amannocci
amannocci previously approved these changes Mar 8, 2024
SylvainJuge
SylvainJuge previously approved these changes Mar 8, 2024
.buildkite/hooks/pre-command Outdated Show resolved Hide resolved
.buildkite/hooks/pre-command Outdated Show resolved Hide resolved
.buildkite/hooks/pre-command Outdated Show resolved Hide resolved
.ci/release.sh Outdated Show resolved Hide resolved
fi

echo "--- Release the binaries to Maven Central :maven: [./mvnw $GOAL)] $DRY_RUN_MSG"
./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee release.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee release.txt
./mvnw -V -s .ci/settings.xml -Pgpg clean ${GOAL} -DskipTests --batch-mode | tee release.txt

.ci/snapshot.sh Outdated Show resolved Hide resolved
reakaleek
reakaleek previously approved these changes Mar 11, 2024
@v1v v1v dismissed stale reviews from reakaleek and SylvainJuge via 594190c March 11, 2024 11:39
@v1v v1v enabled auto-merge (squash) March 11, 2024 11:40
@v1v
Copy link
Member Author

v1v commented Mar 11, 2024

run docs

@v1v
Copy link
Member Author

v1v commented Mar 11, 2024

run docs build

@v1v
Copy link
Member Author

v1v commented Mar 11, 2024

run docs-build rebuild

1 similar comment
@v1v
Copy link
Member Author

v1v commented Mar 11, 2024

run docs-build rebuild

@v1v
Copy link
Member Author

v1v commented Mar 11, 2024

run docs-build

@v1v v1v merged commit 4365056 into main Mar 11, 2024
7 checks passed
@v1v v1v deleted the feature/support-cache-java-agents-buildkite branch March 11, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants