Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: SylvainJuge <[email protected]>
  • Loading branch information
v1v and SylvainJuge authored Mar 11, 2024
1 parent 4f9f5d7 commit 594190c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .buildkite/hooks/pre-command
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ git config --global user.name "apmmachine"
JAVA_VERSION=$(cat .java-version | xargs | tr -dc '[:print:]')
JAVA_HOME="${HOME}/.java/openjdk${JAVA_VERSION}"
export JAVA_HOME
PATH="${JAVA_HOME}/bin:$PATH"
PATH="${JAVA_HOME}/bin:${PATH}"
export PATH

# Fallback to install at runtime
Expand All @@ -59,9 +59,9 @@ if [ ! -d "${JAVA_HOME}" ] ; then
echo "--- Install JDK${JAVA_VERSION} :java:"
JAVA_URL=https://jvm-catalog.elastic.co/jdk
JAVA_PKG="${JAVA_URL}/latest_openjdk_${JAVA_VERSION}_linux.tar.gz"
curl -L --output /tmp/jdk.tar.gz "$JAVA_PKG"
curl -L --output /tmp/jdk.tar.gz "${JAVA_PKG}"
mkdir -p "$JAVA_HOME"
tar --extract --file /tmp/jdk.tar.gz --directory "$JAVA_HOME" --strip-components 1
tar --extract --file /tmp/jdk.tar.gz --directory "${JAVA_HOME}" --strip-components 1
fi

java -version
2 changes: 1 addition & 1 deletion .ci/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ if [[ "$dry_run" == "false" ]] ; then
DRY_RUN_MSG=""
fi

echo "--- Release the binaries to Maven Central :maven: [./mvnw $GOAL)] $DRY_RUN_MSG"
echo "--- Release the binaries to Maven Central :maven: [./mvnw ${GOAL})] ${DRY_RUN_MSG}"
./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee release.txt
4 changes: 2 additions & 2 deletions .ci/snapshot.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ if [[ "$dry_run" == "false" ]] ; then
DRY_RUN_MSG=""
fi

echo "--- Deploy the snapshot :package: [./mvnw $GOAL)] $DRY_RUN_MSG"
./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee snapshot.txt
echo "--- Deploy the snapshot :package: [./mvnw ${GOAL})] ${DRY_RUN_MSG}"
./mvnw -V -s .ci/settings.xml -Pgpg clean ${GOAL} -DskipTests --batch-mode | tee snapshot.txt

0 comments on commit 594190c

Please sign in to comment.