Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: Use static URL value for admin console URL for slack automation #14345

Merged
merged 2 commits into from
Oct 11, 2024
Merged

benchmark: Use static URL value for admin console URL for slack automation #14345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c7b27d
use static URL value for benchmark admin console URL for slack
1pkg Oct 11, 2024
72b88b9
Merge branch 'main' into use-static-url-value-for-benchmark-admin-con…
1pkg Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/benchmark/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ output "apm_server_ip" {
}

output "admin_console_url" {
value = var.run_standalone ? "" : module.ec_deployment[0].admin_console_url
value = var.run_standalone ? "https://cloud.elastic.co/deployments" : module.ec_deployment[0].admin_console_url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be admin.found.no? If you're running it yourself, then you'll be able to see the deployment in the "normal" (user console) UI. But if it's running in CI, then you won't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a big difference, since it only uses this URL when run against the Moxy when no ESS deployment exists.

description = "The admin console URL"
}
Loading