benchmark: Use static URL value for admin console URL for slack automation #14345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @1pkg? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kruskall
approved these changes
Oct 11, 2024
marclop
reviewed
Oct 14, 2024
| @@ -43,6 +43,6 @@ output "apm_server_ip" { | |||
| } | |||
|
|
|||
| output "admin_console_url" { | |||
| value = var.run_standalone ? "" : module.ec_deployment[0].admin_console_url | |||
| value = var.run_standalone ? "https://cloud.elastic.co/deployments" : module.ec_deployment[0].admin_console_url | |||
There was a problem hiding this comment.
Shouldn't this be admin.found.no? If you're running it yourself, then you'll be able to see the deployment in the "normal" (user console) UI. But if it's running in CI, then you won't.
There was a problem hiding this comment.
I don't think there is a big difference, since it only uses this URL when run against the Moxy when no ESS deployment exists.
mergify bot
added a commit
that referenced
this pull request
Oct 14, 2024
…lack automation (#14345) (#14349) (cherry picked from commit 9292d4b) Co-authored-by: Kostiantyn Masliuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This is a small fix to make existing slack automation in benchmark workflow to work as expected with standalone benchmark mode.
Checklist
For functional changes, consider:
How to test these changes
Related issues