Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Revert "feat: bump beats to latest 8.x commit (#14147)" #14309

Merged
merged 3 commits into from
Oct 9, 2024
Merged

[8.x] Revert "feat: bump beats to latest 8.x commit (#14147)" #14309

merged 3 commits into from
Oct 9, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Oct 9, 2024 •
edited
Loading

Motivation/summary

Alternative to #14308

This reverts commit 7f85cd6.

Unblock #14292 to fix #14280. Reverting beats instead of
bumping beats to avoid #14297.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner October 9, 2024 11:01
@carsonip carsonip mentioned this pull request Oct 9, 2024
Merged
2 tasks
@carsonip carsonip changed the title Revert "feat: bump beats to latest 8.x commit (#14147)" [8.x] Revert "feat: bump beats to latest 8.x commit (#14147)" Oct 9, 2024
@carsonip carsonip merged commit dd3cbe4 into elastic:8.x Oct 9, 2024
11 checks passed
This was referenced Oct 9, 2024
Closed
Merged
carsonip added a commit that referenced this pull request Oct 9, 2024
@carsonip
Revert "add flag.Parse so HandlFlags works correctly (#14214)" (#14292)
01237c4 
This reverts commit 7efa6d5.

Require beats bump / revert #14310 (8.x: #14309 )
Part of #14280
mergify bot pushed a commit that referenced this pull request Oct 9, 2024
@carsonip @mergify
Revert "add flag.Parse so HandlFlags works correctly (#14214)" (#14292)
8247106 
This reverts commit 7efa6d5.

Require beats bump / revert #14310 (8.x: #14309 )
Part of #14280

(cherry picked from commit 01237c4)
@mergify mergify bot mentioned this pull request Oct 9, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Oct 9, 2024
@mergify @carsonip
Revert "add flag.Parse so HandlFlags works correctly (#14214)" (#14292)…
1715a5d 
… (#14314)

This reverts commit 7efa6d5.

Require beats bump / revert #14310 (8.x: #14309 )
Part of #14280

(cherry picked from commit 01237c4)

Co-authored-by: Carson Ip <[email protected]>
kruskall added a commit to kruskall/apm-server that referenced this pull request Oct 29, 2024
@kruskall
Revert "[8.x] Revert "feat: bump beats to latest 8.x commit (elastic#…
806033f 
…14147)" (elastic#14309)"

This reverts commit dd3cbe4.
kruskall added a commit to kruskall/apm-server that referenced this pull request Oct 29, 2024
@kruskall
Revert "[8.x] Revert "feat: bump beats to latest 8.x commit (elastic#…
4b2ef6e 
…14147)" (elastic#14309)"

This reverts commit dd3cbe4.
kruskall added a commit to kruskall/apm-server that referenced this pull request Oct 29, 2024
@kruskall
Revert "[8.x] Revert "feat: bump beats to latest 8.x commit (elastic#…
bc95d0c 
…14147)" (elastic#14309)"

This reverts commit dd3cbe4.
kruskall added a commit that referenced this pull request Oct 31, 2024
@kruskall
feat(8.16): bump beats to latest version (#14471)
ae686d6 
* Revert "[8.x] Revert "feat: bump beats to latest 8.x commit (#14147)" (#14309)"

This reverts commit dd3cbe4.

* feat: pin ristretto using replace and bump beats

pin ristretto to a version before generics was added to not break binary
compatibility
kruskall added a commit that referenced this pull request Oct 31, 2024
@kruskall
feat(8.x): bump beats to latest version (#14470)
2c52e11 
* Revert "[8.x] Revert "feat: bump beats to latest 8.x commit (#14147)" (#14309)"

This reverts commit dd3cbe4.

* feat: pin ristretto using replace and bump beats

pin ristretto to a version before generics was added to not break binary
compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @kruskall