Revert "add flag.Parse so HandlFlags works correctly (#14214)" (#14292)

This reverts commit 7efa6d5. Require beats bump / revert #14310 (8.x: #14309 ) Part of #14280 (cherry picked from commit 01237c4)
elastic · Oct 9, 2024 · 8247106 · 8247106
1 parent dd3cbe4
commit 8247106
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/cmd/apm-server/main.go b/cmd/apm-server/main.go
@@ -25,7 +25,6 @@ import (
 )
 
 func main() {
-	beatcmd.InitBeatCmd()
 	rootCmd := beatcmd.NewRootCommand(beatcmd.BeatParams{
 		NewRunner: func(args beatcmd.RunnerParams) (beatcmd.Runner, error) {
 			return beater.NewRunner(beater.RunnerParams{

diff --git a/internal/beatcmd/init.go b/internal/beatcmd/init.go
@@ -19,7 +19,6 @@ package beatcmd
 
 import (
 	cryptorand "crypto/rand"
-	"flag"
 	"log"
 	"math"
 	"math/big"
@@ -39,7 +38,7 @@ import (
 	_ "github.com/elastic/beats/v7/libbeat/publisher/queue/memqueue"
 )
 
-func InitBeatCmd() {
+func init() {
 	initRand()
 	initFlags()
 }
@@ -63,7 +62,6 @@ func initFlags() {
 		}
 	}
 
-	flag.Parse()
 	if err := cfgfile.HandleFlags(); err != nil {
 		log.Fatal(err)
 	}

diff --git a/x-pack/apm-server/main.go b/x-pack/apm-server/main.go
@@ -275,7 +275,6 @@ func cleanup() error {
 }
 
 func Main() error {
-	beatcmd.InitBeatCmd()
 	rootCmd := newXPackRootCommand(
 		func(args beatcmd.RunnerParams) (beatcmd.Runner, error) {
 			return beater.NewRunner(beater.RunnerParams{

diff --git a/x-pack/apm-server/root_test.go b/x-pack/apm-server/root_test.go
@@ -13,7 +13,6 @@ import (
 )
 
 func TestSubCommands(t *testing.T) {
-	beatcmd.InitBeatCmd()
 	rootCmd := newXPackRootCommand(func(beatcmd.RunnerParams) (beatcmd.Runner, error) {
 		panic("unexpected call")
 	})