Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clean up OpenTelemetry docs #11882

Merged
merged 8 commits into from
Nov 1, 2023

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Oct 17, 2023

Motivation/summary

Updates documentation related to OpenTelemetry based on issues found during our docs bug bash last week.

Checklist

Related issues

@colleenmcginnis colleenmcginnis added backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify labels Oct 17, 2023
@colleenmcginnis colleenmcginnis self-assigned this Oct 17, 2023
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner October 17, 2023 23:27
@colleenmcginnis
Copy link
Contributor Author

👋 @AlexanderWert @elastic/apm-server I'm looking for a review on these minor updates!

simitt
simitt previously approved these changes Oct 27, 2023
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also wait for review from @AlexanderWert as he requested some of the changes, but LGTM

bmorelli25
bmorelli25 previously approved these changes Oct 30, 2023
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. @AlexanderWert are you okay with these changes?

AlexanderWert
AlexanderWert previously approved these changes Oct 31, 2023
Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor corrections regarding the links and naming of the Elastic / Elasticsearch exporters.

Otherwise, LGTM.

docs/otel-limitations.asciidoc Outdated Show resolved Hide resolved
docs/otel-limitations.asciidoc Outdated Show resolved Hide resolved
@colleenmcginnis colleenmcginnis requested a review from a team October 31, 2023 13:45
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) November 1, 2023 14:17
@colleenmcginnis
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@colleenmcginnis colleenmcginnis merged commit 691b526 into elastic:main Nov 1, 2023
5 checks passed
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* reduce content on aws lambda support

* update otel links

* clarify env var example

* use lens instead of tsvb

* remove resource attributes link

* apply suggestions from code review

Co-authored-by: Alexander Wert <[email protected]>

---------

Co-authored-by: Alexander Wert <[email protected]>
(cherry picked from commit 691b526)

# Conflicts:
#	docs/otel-metrics.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* reduce content on aws lambda support

* update otel links

* clarify env var example

* use lens instead of tsvb

* remove resource attributes link

* apply suggestions from code review

Co-authored-by: Alexander Wert <[email protected]>

---------

Co-authored-by: Alexander Wert <[email protected]>
(cherry picked from commit 691b526)
mergify bot added a commit that referenced this pull request Nov 1, 2023
* reduce content on aws lambda support

* update otel links

* clarify env var example

* use lens instead of tsvb

* remove resource attributes link

* apply suggestions from code review

Co-authored-by: Alexander Wert <[email protected]>

---------

Co-authored-by: Alexander Wert <[email protected]>
(cherry picked from commit 691b526)

Co-authored-by: Colleen McGinnis <[email protected]>
@colleenmcginnis colleenmcginnis deleted the obs-docs-issue-3291 branch November 2, 2023 16:27
mergify bot added a commit that referenced this pull request Nov 3, 2023
* docs: Clean up OpenTelemetry docs (#11882)

* reduce content on aws lambda support

* update otel links

* clarify env var example

* use lens instead of tsvb

* remove resource attributes link

* apply suggestions from code review

Co-authored-by: Alexander Wert <[email protected]>

---------

Co-authored-by: Alexander Wert <[email protected]>
(cherry picked from commit 691b526)

# Conflicts:
#	docs/otel-metrics.asciidoc

* fix merge conflict

---------

Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify
Projects
None yet
5 participants