Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix java 11 and java 21 test failures #3344

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix java 11 and java 21 test failures #3344

merged 2 commits into from
Oct 3, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Oct 3, 2023 •
edited
Loading

What does this PR do?

  • Keep tests compatible with java 11, json-unit is now relying on JDK 17 as minimum requirement for version 3.x
  • use zulu JDk 21 GA instead of the early-access (EA) version that was used in our tests.

Checklist

@SylvainJuge SylvainJuge added the ci:jdk-compatibility Enables JDK compatibility tests in build pipeline label Oct 3, 2023
@SylvainJuge SylvainJuge changed the title keep java11 compat. for jsonunit fix java 11 and java 21 test failures Oct 3, 2023
@SylvainJuge SylvainJuge enabled auto-merge (squash) October 3, 2023 10:51
@SylvainJuge SylvainJuge merged commit 9d1a101 into elastic:main Oct 3, 2023
@SylvainJuge SylvainJuge deleted the fix-jsonunit-java11 branch October 5, 2023 08:36
schikin pushed a commit to schikin/apm-agent-java that referenced this pull request Oct 11, 2023
@SylvainJuge @schikin
fix java 11 and java 21 test failures (elastic#3344)
e558260 
* keep java11 compat. for jsonunit

* use GA JDK 21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

Assignees
No one assigned
Labels
agent-java ci:jdk-compatibility Enables JDK compatibility tests in build pipeline
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainJuge @v1v