Skip to content

Commit

Permalink
fix java 11 and java 21 test failures (elastic#3344)
Browse files Browse the repository at this point in the history
* keep java11 compat. for jsonunit

* use GA JDK 21
  • Loading branch information
SylvainJuge authored and schikin committed Oct 11, 2023
1 parent 0e01015 commit e558260
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ jobs:
distribution: 'temurin'
- version: 20
distribution: 'temurin'
- version: 21-ea
- version: 21
distribution: 'zulu'
steps:
- uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@

<version.testcontainers>1.16.3</version.testcontainers>

<!-- latest version compiled for java 11 -->
<version.jsonunit>2.38.0</version.jsonunit>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

Expand Down Expand Up @@ -768,7 +771,7 @@
<dependency>
<groupId>net.javacrumbs.json-unit</groupId>
<artifactId>json-unit-assertj</artifactId>
<version>3.2.2</version>
<version>${version.jsonunit}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down

0 comments on commit e558260

Please sign in to comment.