Aws faas #3340

raphw · 2023-09-29T18:08:54Z

Factor out AWS module to not depend on agent-core module, adding Faas and ServiceOrigin abstraction.

Edit:
Fixes #3016

…n already be read by constructor injection. Add warning to use the global tracer from listeners, and make init method unavailable for regular plugins.

…e dependencies on core module.

…ementation.

# Conflicts: # apm-agent-plugins/apm-opentelemetry/apm-opentelemetry-metricsdk-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/SdkMeterProviderBuilderInstrumentation.java

github-actions · 2023-09-29T18:09:14Z

👋 @raphw Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

apm-agent-core/src/main/java/co/elastic/apm/agent/context/InitializableLifecycleListener.java

SylvainJuge

Another awesome refactor, thanks a lot @raphw !! I am approving this to get it running in CI.

apm-agent-core/src/main/java/co/elastic/apm/agent/context/InitializableLifecycleListener.java

apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/LifecycleListener.java

SylvainJuge · 2023-10-09T12:27:08Z

apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/direct/DirectSpan.java

+
+import javax.annotation.Nullable;
+
+public interface DirectSpan<T extends DirectSpan<T>> extends AbstractDirectSpan<T>, Span<T> {


[question] I am not sure to understand what is the purpose and benefit of this direct package and the classes within it, could you clarify a bit here ?

I stacked these PRs as they touch quite some of the same code and I wanted to avoid lengthy merges, I should have documented that order, sorry. The direct package can be considered as API for creating explicit spans and recording explicit data as with open tracing and open telementry. Maybe explicit would be a better name for it.

SylvainJuge · 2023-10-09T12:32:42Z

apm-agent-tracer/src/test/java/co/elastic/apm/agent/tracer/direct/ProbabilitySamplerTest.java

-            .describedAs("sample rate header should return same instance on each call")
-            .isSameAs(sampler.getTraceStateHeader());
-    }
-


[question] what makes this test not relevant anymore ?

The test is still there, it is just moved to the tracer-api module. The header code is however moved out, so some of the code was removed.

SylvainJuge · 2023-10-09T12:45:39Z

apm-agent-core/src/main/java/co/elastic/apm/agent/logging/ApmServerLogAppender.java

-    public LifecycleListener getInitListener() {
-        return new AbstractLifecycleListener() {
+    public InitializableLifecycleListener getInitListener() {
+        class InitListener extends AbstractLifecycleListener implements InitializableLifecycleListener {


[minor] why not use a simple anonymous class here ?

An anonymous class cannot implement two classes/interfaces as the same time.

apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/TraceContext.java

...-plugin/src/main/java/co/elastic/apm/agent/micrometer/MicrometerMeterRegistrySerializer.java

...y-metricsdk-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/MetricSetSerializer.java

SylvainJuge · 2023-10-09T13:03:03Z

...plugin/src/main/java/co/elastic/apm/agent/opentracingimpl/ApmSpanBuilderInstrumentation.java

                                                                    Map<String, Object> tags,
                                                                    String operationName, long microseconds,
                                                                    @Nullable Iterable<Map.Entry<String, String>> baggage, ClassLoader applicationClassLoader) {
-                AbstractSpan<?> result = null;
-                ElasticApmTracer tracer = OpenTracingBridgeInstrumentation.tracer.require(ElasticApmTracer.class);


[question] does it means that we get rid of the OpenTracing bridge ? We are thinking about removing that for a while, but doing so would also require us to officially deprecate and document this.

Probably, but I would separate this out into another PR.

apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/reporting/DataWriter.java

…ializableLifecycleListener.java Co-authored-by: SylvainJuge <[email protected]>

…ecycleListener.java Co-authored-by: SylvainJuge <[email protected]>

# Conflicts: # apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/AbstractSpan.java # apm-agent-plugins/apm-awslambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/helper/S3TransactionHelper.java

botelastic · 2024-01-19T12:36:15Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

botelastic · 2024-02-02T12:36:19Z

Hi! This issue has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this issue if you think it should stay open. Thank you for your contribution!

raphw · 2024-02-06T17:47:50Z

Closing this in favor of #3516

raphw added 18 commits September 28, 2023 09:28

Factor out lifecycle listener and remove tracer arguments as those ca…

bd6bf29

…n already be read by constructor injection. Add warning to use the global tracer from listeners, and make init method unavailable for regular plugins.

Move metrics and log reporting to ReportingTracer, and remove obsolet…

b37db58

…e dependencies on core module.

Add data writer abstraction to decouple plugins from Json writer impl…

f92b941

…ementation.

Merge branch 'main' into metric-api

d8b89ab

# Conflicts: # apm-agent-plugins/apm-opentelemetry/apm-opentelemetry-metricsdk-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/SdkMeterProviderBuilderInstrumentation.java

Remove unused import after merge.

2d6e4ac

Remove ASCII method as it can be replaced by more convenient calls.

fa6181b

Simplify API for JSON writing.

da91e15

Further simplify API for JSON writing.

c01c2fa

Remove test code.

b136b3d

Add toString function to support tests.

72e5079

Avoid escaping of suffix.

e3de0e4

Avoid duplicate escaping of suffix.

d7887c3

Add support for direct tracing.

ae642f8

Fix mock in test.

742e76e

Fix configuration exporter.

3ea33c8

Fix incorrect API port.

6830206

Add direct transaction equivalent.

020de77

Remove dependency of AWS tracer onto agent-core module.

9fefdb5

github-actions bot added agent-java community Issues and PRs created by the community triage labels Sep 29, 2023

SylvainJuge reviewed Oct 9, 2023

View reviewed changes

apm-agent-core/src/main/java/co/elastic/apm/agent/context/InitializableLifecycleListener.java Outdated Show resolved Hide resolved

SylvainJuge previously approved these changes Oct 9, 2023

View reviewed changes

SylvainJuge removed the triage label Oct 9, 2023

SylvainJuge mentioned this pull request Oct 9, 2023

Offer direct span creation API for use within explicit tracers. #3336

Closed

Update apm-agent-core/src/main/java/co/elastic/apm/agent/context/Init…

1ff99be

…ializableLifecycleListener.java Co-authored-by: SylvainJuge <[email protected]>

raphw dismissed SylvainJuge’s stale review via 1ff99be October 9, 2023 19:12

raphw and others added 2 commits October 9, 2023 21:13

Update apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/Lif…

ca6ee7f

…ecycleListener.java Co-authored-by: SylvainJuge <[email protected]>

Rename init lifecycle listener.

9925508

raphw added 3 commits October 9, 2023 21:30

Merge remote-tracking branch 'rafael/aws-faas' into aws-faas

c823e5b

Add test for header caching.

f06060f

Merge branch 'main' into aws-faas

b0bb5c0

# Conflicts: # apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/AbstractSpan.java # apm-agent-plugins/apm-awslambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/helper/S3TransactionHelper.java

botelastic bot added the stalled label Jan 19, 2024

botelastic bot closed this Feb 2, 2024

jackshirazi reopened this Feb 2, 2024

botelastic bot removed the stalled label Feb 2, 2024

raphw closed this Feb 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aws faas #3340

Aws faas #3340

raphw commented Sep 29, 2023 •

edited by SylvainJuge

Loading

github-actions bot commented Sep 29, 2023

SylvainJuge left a comment

SylvainJuge Oct 9, 2023

raphw Oct 9, 2023

SylvainJuge Oct 9, 2023

raphw Oct 9, 2023

SylvainJuge Oct 9, 2023

raphw Oct 9, 2023

SylvainJuge Oct 9, 2023

raphw Oct 9, 2023

botelastic bot commented Jan 19, 2024

botelastic bot commented Feb 2, 2024

raphw commented Feb 6, 2024


		import javax.annotation.Nullable;

		public interface DirectSpan<T extends DirectSpan<T>> extends AbstractDirectSpan<T>, Span<T> {

Aws faas #3340

Aws faas #3340

Conversation

raphw commented Sep 29, 2023 • edited by SylvainJuge Loading

github-actions bot commented Sep 29, 2023

SylvainJuge left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

botelastic bot commented Jan 19, 2024

botelastic bot commented Feb 2, 2024

raphw commented Feb 6, 2024

raphw commented Sep 29, 2023 •

edited by SylvainJuge

Loading