Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer direct span creation API for use within explicit tracers. #3336

Closed
wants to merge 17 commits into from

Conversation

raphw
Copy link
Contributor

@raphw raphw commented Sep 28, 2023

Adds a DirectTracer abstraction that allows for recording data explicitly, for example when using tracer APIs such as OpenTelementry.

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Sep 28, 2023
@github-actions
Copy link

👋 @raphw Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@SylvainJuge
Copy link
Member

Hi @raphw , if I am not mistaken most of the changes here are also included in #3340 , is that correct ?

For now the only concern that I have is the exact meaning we want to give to direct implementations, as it's not straightforward to know which one to pick apart from relying on what is available in the classpath, do you have a few other naming strategies that would be less abstract ?

@raphw
Copy link
Contributor Author

raphw commented Oct 9, 2023

Direct is maybe not the best term. Maybe explicit is a better prefix?

@botelastic
Copy link

botelastic bot commented Dec 11, 2023

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the stalled label Dec 11, 2023
@botelastic
Copy link

botelastic bot commented Dec 25, 2023

Hi! This issue has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this issue if you think it should stay open. Thank you for your contribution!

@botelastic botelastic bot closed this Dec 25, 2023
@jackshirazi jackshirazi reopened this Jan 2, 2024
@botelastic botelastic bot removed the stalled label Jan 2, 2024
@raphw raphw closed this Feb 6, 2024
@raphw
Copy link
Contributor Author

raphw commented Feb 6, 2024

I am creating a new, independant PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants