-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer direct span creation API for use within explicit tracers. #3336
Conversation
…n already be read by constructor injection. Add warning to use the global tracer from listeners, and make init method unavailable for regular plugins.
…e dependencies on core module.
# Conflicts: # apm-agent-plugins/apm-opentelemetry/apm-opentelemetry-metricsdk-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/SdkMeterProviderBuilderInstrumentation.java
👋 @raphw Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
Hi @raphw , if I am not mistaken most of the changes here are also included in #3340 , is that correct ? For now the only concern that I have is the exact meaning we want to give to |
Direct is maybe not the best term. Maybe explicit is a better prefix? |
Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as |
Hi! This issue has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this issue if you think it should stay open. Thank you for your contribution! |
I am creating a new, independant PR. |
Adds a
DirectTracer
abstraction that allows for recording data explicitly, for example when using tracer APIs such as OpenTelementry.