Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rspec deprecated warning #5

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

hkobayash
Copy link

fix below deprecated warnings.

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to raise BacklogKit::Error with "ConnectionError - getaddrinfo: nodename nor servname provided, or not known"` not `expect(value).to raise BacklogKit::Error with "ConnectionError - getaddrinfo: nodename nor servname provided, or not known"`

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (075f812) to head (a2b2993).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          568       568           
=========================================
  Hits           568       568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkobayash hkobayash merged commit 4dd9173 into main Apr 17, 2024
17 checks passed
@hkobayash hkobayash deleted the fix/rspec_deprecated_warning branch April 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant