fix rspec deprecated warning (#5)

elastic-infra · Apr 17, 2024 · 4dd9173 · 4dd9173
1 parent 075f812
commit 4dd9173
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/spec/backlog_kit/client_spec.rb b/spec/backlog_kit/client_spec.rb
@@ -280,8 +280,7 @@
         allow_any_instance_of(Faraday::Connection).to receive(:send).and_raise(Faraday::ConnectionFailed, message)
       end
 
-      subject { -> { response } }
-      it { is_expected.to raise_error(BacklogKit::Error, "ConnectionError - #{message}") }
+      it { expect { subject }.to raise_error(BacklogKit::Error, "ConnectionError - #{message}") }
     end
   end
 

diff --git a/spec/backlog_kit/response/raise_error_spec.rb b/spec/backlog_kit/response/raise_error_spec.rb
@@ -20,7 +20,7 @@
   end
 
   describe '#on_complete' do
-    subject { -> { response.on_complete(faraday_env_mock) } }
+    subject { response.on_complete(faraday_env_mock) }
 
     context 'when error code contains 1' do
       let(:error_code) { 1 }
@@ -79,27 +79,27 @@
 
     context 'when error code contains unexpected code' do
       let(:error_code) { 99 }
-      it { is_expected.to raise_error(BacklogKit::Error, "[ERROR 1] UnexpectedError - エラー1 (CODE: #{error_code}), [ERROR 2] UnexpectedError - エラー2 (CODE: #{error_code})") }
+      it { expect { subject }.to raise_error(BacklogKit::Error, "[ERROR 1] UnexpectedError - エラー1 (CODE: #{error_code}), [ERROR 2] UnexpectedError - エラー2 (CODE: #{error_code})") }
     end
 
     context 'when status code is 204' do
       let(:faraday_env_status) { 204 }
-      it { is_expected.not_to raise_error }
+      it { expect { subject }.not_to raise_error }
     end
 
     context 'when content type is not json' do
       let(:faraday_env_headers) { { 'content-type' => 'image/gif' } }
-      it { is_expected.not_to raise_error }
+      it { expect { subject }.not_to raise_error }
     end
 
     context 'when json body is array' do
       let(:faraday_env_body) { [{ 'key1' => 'value1' }].to_json }
-      it { is_expected.not_to raise_error }
+      it { expect { subject }.not_to raise_error }
     end
 
     context 'when json body does not contains error' do
       let(:faraday_env_body) { { 'key1' => 'value1' }.to_json }
-      it { is_expected.not_to raise_error }
+      it { expect { subject }.not_to raise_error }
     end
   end
 

diff --git a/spec/support/shared_examples_for.rb b/spec/support/shared_examples_for.rb
@@ -1095,15 +1095,15 @@
 end
 
 shared_examples_for 'a invalid request error' do
-  subject { -> { response.body } }
-  it { is_expected.to raise_error(BacklogKit::Error, "[ERROR 1] InvalidRequestError - error.unknownParameter : #{invalid_param_key} (CODE: 7)") }
+  subject { response.body }
+  it { expect { subject }.to raise_error(BacklogKit::Error, "[ERROR 1] InvalidRequestError - error.unknownParameter : #{invalid_param_key} (CODE: 7)") }
 end
 
 shared_examples_for 'raise errors' do
   let(:error_class_name) do
     BacklogKit::Response::RaiseError::CODE_ERRORS[error_code].name.demodulize
   end
 
-  subject { -> { response.on_complete(faraday_env_mock) } }
-  it { is_expected.to raise_error(BacklogKit::Error, "[ERROR 1] #{error_class_name} - エラー1 (CODE: #{error_code}), [ERROR 2] #{error_class_name} - エラー2 (CODE: #{error_code})") }
+  subject { response.on_complete(faraday_env_mock) }
+  it { expect { subject }.to raise_error(BacklogKit::Error, "[ERROR 1] #{error_class_name} - エラー1 (CODE: #{error_code}), [ERROR 2] #{error_class_name} - エラー2 (CODE: #{error_code})") }
 end