remove inlineJsrBytecode following upstream removal in jdt #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <[email protected]>
|
Fixes #3188 |
LorenzoBettini
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
IIRC that's required because we use, in POM, an ancient version of jdt where this wasn't set by default, and in the recent versions the option is not even available anymore, right?
I think we should keep track of these reflection hacks so that we'll remove them when we switch to Java 17 and update to more recent version of jdt in POM as well.
|
@LorenzoBettini as my committer status is caught in eclipse fdn bureaucracy can you please merge |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.