Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced JDT Facade project #3204

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Introduced JDT Facade project #3204

merged 2 commits into from
Oct 8, 2024

Conversation

LorenzoBettini
Copy link
Contributor

@LorenzoBettini LorenzoBettini commented Sep 24, 2024

For #3129

This is a possible JDT facade project I had in mind.

For the moment, it only includes #3189 but I was planning to confine there all, or most, of our usage of JDT internals.

However, I'd first start with reflection hacks.

I'd like to have some initial feedback @cdietrich @szarnekow

Copy link

github-actions bot commented Sep 24, 2024

Test Results

  6 460 files  ±0    6 460 suites  ±0   3h 8m 40s ⏱️ - 4m 15s
 43 242 tests ±0   42 658 ✅ ±0    584 💤 ±0   0 ❌ ±0 
170 307 runs   - 2  167 936 ✅ ±0  2 358 💤 ±0  13 ❌  - 2 

Results for commit c6989bb. ± Comparison against base commit 3f13054.

♻️ This comment has been updated with latest results.

@LorenzoBettini
Copy link
Contributor Author

@cdietrich @szarnekow, could we merge this one so that the JDT Facade project is introduced, and then we or I can add other JDT internal calls and hacks to the project?

@LorenzoBettini LorenzoBettini merged commit ff38d44 into main Oct 8, 2024
12 of 17 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_3129 branch October 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant