-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified quick use button #541
Modified quick use button #541
Conversation
SergioCasCeb
commented
Dec 6, 2023
- Changed the quick-use button to a simpler, more obvious variation.
- Instead of utilizing an icon that implies import, the button now has the simple text of "use"
- Changed the quick use button to a simpler, more obvious variation.
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@danielpeintner @mkovatsc do you prefer this more direct "USE" button compared to the icon? |
I think it is easier to understand when reading the text without hovering over. It could even read "LOAD" to me... since I would be unsure what "USE" means... anyhow fine as is. |
- Changed the quick use button to a simpler, more obvious variation.
…oCasCeb/playground into simpler-user-button-sergio
@danielpeintner now we use load as it also makes more sense to me. @SergioCasCeb there should be no changes to the copyright years in this PR. Can you rebase it? |
@egekorkan what exactly do you mean with the copying years? Also should the button, when opening the example card, also say load instead of apply to avoid any confusion between the functionality of each button? |
I hadn't seen that sadly. I think that row with two buttons can either be removed (not sure yet). For now, the "apply" button should also say load. |
Currently, this PR has 97 file changes but they are due to copyright years (see screenshot below) changing. It even shows the change again (not sure why) since #546 has already did the correction. We are now using the creation date instead of the current year. |
Ok, I will change the text of the other Button. And rebase the branch to fix the copyright texts. |
- The button text has been changed from Apply to Load to match the text of the quick use button
- Changed the quick use button to a simpler, more obvious variation.
- Changed the quick use button to a simpler, more obvious variation.
- The button text has been changed from Apply to Load to match the text of the quick use button
…oCasCeb/playground into simpler-user-button-sergio
@egekorkan , I fixed the button name and some styling issues. Still, regarding the copyright issue, I got a bit confused because I checked some other packages in the master branch from the eclipse-thingweb repository and they also have different dates. By date of creation do you mean the creation of the individual package or the project itself? Also I don't think rebasing will help me do that, but if you want, with the search function in VSCode I can set everything again to the correct date, or should that be done in another PR on itself? |
Changing the base branch twice solved the copyright year issues. Merging |