Reduced the examples padding #539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think that the padding can be reduced slightly more but I will merge it (once conflicts are resolved) so that we can have two versions to compare if needed |
egekorkan
approved these changes
Dec 7, 2023
|
Yes, the padding could be reduced more, but the quick-use button hinders that strongly. So if the padding were to be reduced more I recommend moving to one of the other options I suggested on PR #540 or #541. @egekorkan |
SergioCasCeb
force-pushed
the
reduce-example-padding-sergio
branch
from
280771c to
2d692b9
Compare
|
@SergioCasCeb was closing the PR intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size and spacing of the examples has been reduced, to provide a better look and feel