feat(binding-coap): remove cov:observe subprotocol #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
coap-update
branch
2 times, most recently
from
44d1dec to
47a02d7
Compare
danielpeintner
approved these changes
Aug 14, 2024
Do you want to list/collect the future work in an issue? |
|
Thank you for the feedback, @danielpeintner :)
I've opened #1316 to keep track of the additions needed to support the new behavior :) |
|
Since the PR got approved and #1316 is created, I would go ahead and merge this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the recent changes applied to the CoAP Binding Template document in w3c/wot-binding-templates#353, removing the
cov:observesubprotocol from the TDs that are generated when adding a CoAP server to a servient.In order to better cover the consumer behavior described in the CoAP binding template (falling back to polling if the server does not support CoAP observe), some more work is needed that might also need to be applied to the underlying CoAP libraries. I will try to cover these aspects soon in a follow-up PR.