feat(binding-coap): remove cov:observe subprotocol

eclipse-thingweb · Aug 12, 2024 · 47a02d7 · 47a02d7
1 parent 0eb1d53
commit 47a02d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/packages/binding-coap/src/coap-server.ts b/packages/binding-coap/src/coap-server.ts
@@ -35,7 +35,7 @@ import { MdnsIntroducer } from "./mdns-introducer";
 import { PropertyElement, DataSchema, ActionElement, EventElement } from "wot-thing-description-types";
 import { CoapServerConfig } from "./coap";
 import { DataSchemaValue } from "wot-typescript-definitions";
-import { filterPropertyObserveOperations, getPropertyOpValues } from "./util";
+import { getPropertyOpValues } from "./util";
 
 const { debug, warn, info, error } = createLoggers("binding-coap", "coap-server");
 
@@ -248,23 +248,14 @@ export default class CoapServer implements ProtocolServer {
                     continue;
                 }
 
-                let subprotocol: string | undefined;
-
-                const observeOpValues = filterPropertyObserveOperations(formOpValues);
-
-                if (observeOpValues.length > 0) {
-                    subprotocol = "cov:observe";
-                }
-
                 const form = this.createAffordanceForm(
                     base,
                     this.PROPERTY_DIR,
                     offeredMediaType,
                     formOpValues,
                     thing.uriVariables,
                     propertyName,
-                    property.uriVariables,
-                    subprotocol
+                    property.uriVariables
                 );
 
                 this.addFormToAffordance(form, property);
@@ -299,8 +290,7 @@ export default class CoapServer implements ProtocolServer {
                 ["subscribeevent", "unsubscribeevent"],
                 thing.uriVariables,
                 eventName,
-                event.uriVariables,
-                "cov:observe"
+                event.uriVariables
             );
 
             this.addFormToAffordance(form, event);

diff --git a/packages/binding-coap/test/coap-server-test.ts b/packages/binding-coap/test/coap-server-test.ts
@@ -679,7 +679,6 @@ class CoapServerTest {
 
                         if (observeOpValuePresent) {
                             observeOpValueFormCount++;
-                            expect(form.subprotocol).to.eql("cov:observe");
                         }
 
                         const readWriteOpValueCount = filterPropertyReadWriteOperations(