Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button toggle states "on" and "over" not obvious on default dark theme #648

Closed
OlivierJaquemet opened this issue Mar 20, 2023 · 3 comments
Closed

Comments

@OlivierJaquemet
Copy link

Toggle state is described in the Eclipse UI Guidelines :
https://eclipse-platform.github.io/ui-best-practices/#toggled_states

When using the default light mode theme, the "on" and "over" states are quite obvious.

However, when using the default dark mode theme, the "on" and "over" states are almost indistinguishable from the "off" states, as seen in thefollowing captures which demonstrate the issue using the Scroll Lock button of the Console view.

Scroll lock - toggle state - OFF state :
scroll lock - toggle state - OFF

Scroll lock - toggle state - OVER state :
scroll lock - toggle state - OVER

Scroll lock - toggle state - ON state :
scroll lock - toggle state - ON

Captured on Eclipse 2023-03 (4.27.0), on Windows 10.

@OlivierJaquemet
Copy link
Author

PS :

  • I could not change the behavior using the OS settings
  • I would like the default Eclipse installation to be provide the best behavior and that's why I don't want to install plugin from the markeplace to fix this

@BeckerWdf
Copy link
Contributor

this is a duplicate of #340

@OlivierJaquemet
Copy link
Author

Thank you @BeckerWdf for the triage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants