Fire the correct property in Product#setIncludeJre #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS See eclipse-pde#1278
laeubi
approved these changes
May 31, 2024
HannesWell
approved these changes
May 31, 2024
|
Actually we already have RC2 promotion today with the I-build from yesterday. So unless there is a RC2a for the SDK, this will fix will not be in Eclipse 2024-06. |
|
I'm not sure we should be committing changes before master is open again.... |
|
@HannesWell For the future please don't push changes at that state of the cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS
Fixes #1278