Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong property fired in Product#setIncludeJre #1278

Closed
Phillipus opened this issue May 30, 2024 · 1 comment · Fixed by #1279
Closed

Wrong property fired in Product#setIncludeJre #1278

Phillipus opened this issue May 30, 2024 · 1 comment · Fixed by #1279

Comments

@Phillipus
Copy link
Contributor

The property P_INCLUDE_LAUNCHERS is fired here:

eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/product/Product.java

Lines 899 to 906 in 9648456

public void setIncludeJre(boolean include) {
boolean old = fIncludeJre;
fIncludeJre = include;
if (isEditable()) {
firePropertyChanged(P_INCLUDE_LAUNCHERS, Boolean.toString(old), Boolean.toString(fIncludeJre));
}
}

It should be P_INCLUDE_JRE
Phillipus added a commit to Phillipus/eclipse.pde that referenced this issue May 30, 2024
@Phillipus
Fire the correct property in Product#setIncludeJre
5871126 
The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS

See eclipse-pde#1278
@Phillipus Phillipus mentioned this issue May 30, 2024
Merged
@Phillipus
Copy link
Contributor Author

PR #1279

@HannesWell HannesWell linked a pull request May 31, 2024 that will close this issue
Fire the correct property in Product#setIncludeJre #1279
Merged
HannesWell pushed a commit that referenced this issue May 31, 2024
@Phillipus @HannesWell
Fire the correct property in Product#setIncludeJre
d92416a 
The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS

See #1278
fedejeanne pushed a commit to fedejeanne/eclipse.pde that referenced this issue Jul 31, 2024
@Phillipus @fedejeanne
Fire the correct property in Product#setIncludeJre
253b0c8 
The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS

See eclipse-pde#1278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fire the correct property in Product#setIncludeJre Phillipus/eclipse.pde
1 participant
@Phillipus