Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable workflows #78

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Switch to reusable workflows #78

merged 1 commit into from
Dec 20, 2023

Conversation

markpatton
Copy link
Contributor

@markpatton markpatton commented Dec 13, 2023

Switch to reusable snapshot and release workflows from main. Note that there is no longer a separate update image workflow. For simplicity, the snapshot workflow also updates the images.

Testing resulted in two full releases being made, 1.3.0-RC1 and 1.3.0-RC2. The commits for RC1 went to a branch and were lost when history was rewritten. The commits for RC2 went to main. RC1 and RC2 should be identical in any case. After merge the RC1 tag should be updated to be the same as the RC2 tag.

@markpatton markpatton marked this pull request as ready for review December 19, 2023 14:53
@markpatton markpatton requested a review from jabrah December 19, 2023 14:53
Copy link
Contributor

@jabrah jabrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification. Looking good, especially considering the successful test runs

@markpatton markpatton merged commit b29abb5 into main Dec 20, 2023
1 check passed
@markpatton markpatton deleted the 846-release-workflow branch December 20, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants