The toplevel module version commit should only happen if the release succeeds

[markpatton]

Currently the release action updates the toplevel module version and then calls the release plugin. This can cause problems if the release fails because the commit will have been made. The version update should be done as part of the release plugin work if possible. It is updating the submodule versions.

[jabrah]

We should probably also allow the release plugin to push (version bump) commits and tags itself, instead of pushing manually

[markpatton]

For release of child modules of main, pass-core and pass support it works like:

1. Update parent dependency to release version
2. Commit pom change
3. Release plugin prepare
4. Release plugin perform in release profile
5. Update parent pom to new dev version (submodules should be at dev version)
6. Commit pom change and push all changes
7. Create docker image for dev by running maven deploy with release profile
8. Push git tags
9. Push docker images

[markpatton]

One thought is the maven release plugin really isn't providing value. We're working around it more than taking advantage of it.

Proposal:

1. Update parent dependency to release version
2. Update version to release
3. Run maven deploy
4. Push release docker image
5. Commit pom changes, create tag, and push changes
6. Repeat the above with the next dev version

The deploy step is what sometimes fails trying to close the sonatype repository. But the upload to maven central actually succeeds.

If the deploy fails, we should ping maven central for 20 minutes, before giving up. But only it it fails on sonatype. Could check for exit code 1 and an error message like Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin.

If the deploy ends up failing completely, nothing will have been committed to github, no images will be pushed. We can just retry without making any changes later.

[markpatton]

build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin is missing