Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFTP transport to deposit services #71

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Nov 2, 2023

This PR contains the following:

  • Consolidated transport modules into deposit-core
  • Added SFTP transport. The Apache MINA SSHD (https://github.com/apache/mina-sshd) has been added as a dependency to provide the SFTP client.

There is also a PR in pass-docker to change the ftp service to sftp: eclipse-pass/pass-docker#358

@rpoet-jh rpoet-jh requested a review from markpatton November 2, 2023 17:20
@rpoet-jh rpoet-jh self-assigned this Nov 2, 2023
@rpoet-jh rpoet-jh linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass for me locally.

@rpoet-jh rpoet-jh force-pushed the russ-780-deposit-svc-sftp branch from 81a834a to 7bd7dd0 Compare November 6, 2023 13:47
@rpoet-jh rpoet-jh merged commit 1d08b49 into main Nov 6, 2023
2 checks passed
@markpatton markpatton deleted the russ-780-deposit-svc-sftp branch December 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SFTP for Deposit Services
2 participants