-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
731 Performance Analysis for Nihms Loader #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Revert back to original -Cleanup
tsande16
force-pushed
the
731-perfom-analysis-nihms-loader
branch
from
October 10, 2023 14:07
59dba49
to
a9421db
Compare
Forgot to rebase before initializing the PR. It has now been rebased with main. |
rpoet-jh
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Tim! mvn verify
completed in ~5 mins for the whole nihms project on my machine, that is a great improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified areas to improve to the run-time of the Nihms Loader. The goal was to get it under 5 minutes run-time and currently it runs at 4m56s locally.
Notable changes:
TransformAndLoadSmokeIT
they were running null. Since there is another retry with a timeout (required by the ext service), this was consuming more time than necessary. It is now using wiremock and an added system env variable to set the timeout to 0ms.TransformAndLoadSmokeIT
. There were a few cases that were similar to each other, and one of them could be removed and not interfere with coverage.To test:
mvn verify