Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Analysis on NihmsLoader ITs #731

Closed
tsande16 opened this issue Sep 14, 2023 · 1 comment
Closed

Performance Analysis on NihmsLoader ITs #731

tsande16 opened this issue Sep 14, 2023 · 1 comment
Assignees
@tsande16
Milestone
1.1.0 (October)

Comments

@tsande16
Copy link
Contributor

The NihmsLoader nihms-data-transform-load takes ~584ms to run. Analysis needs to be performed to see if the ITs in this module can be optimized.

  • One area that can reduce unnecessary time is entrez lookup for the test records in the TransformAndLoadSmokeIT. These are test PMIDs in the resource folder and will not have a successful lookup. The entrez lookup can be mocked for this IT to speed up the test.
@tsande16 tsande16 added this to the Post 1.0.0 milestone Sep 14, 2023
@tsande16 tsande16 self-assigned this Sep 14, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Sep 14, 2023
@tsande16 tsande16 moved this from Backlog to In Progress in Eclipse PASS Oct 2, 2023
@tsande16 tsande16 modified the milestones: Post 1.0.0, October launch Oct 2, 2023
@tsande16 tsande16 moved this from In Progress to Peer Review/QA in Eclipse PASS Oct 10, 2023
@tsande16 tsande16 moved this from Peer Review/QA to Done in Eclipse PASS Oct 11, 2023
@tsande16 tsande16 reopened this Oct 11, 2023
@github-project-automation github-project-automation bot moved this from Done to Backlog in Eclipse PASS Oct 11, 2023
@tsande16 tsande16 moved this from Backlog to Done in Eclipse PASS Oct 11, 2023
@tsande16
Copy link
Contributor Author

Don't think I can link after PR is merged and closed?
Here it is: eclipse-pass/pass-support#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsande16 tsande16

Labels
None yet
Projects
Eclipse PASS
Archived in project
Milestone
1.1.0 (October)
Development

No branches or pull requests
1 participant
@tsande16