Remove the user directory service api call from grant loader #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have local manual testing to perform, but I figured I'd open this now to start the review. |
|
Closing while making discussed changes to remove user dir api call all together since locatorIds are populated by User Service in Pass on user login. |
rpoet-jh
changed the title
markpatton
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-pass/main#746
This PR has the following changes:
Removes the call to user directory api to get the HopkinsID for a user. Now if a User is created because it was not found in Pass, only the employeeId and jhed (eppn) locatorIds are created in the User. The HopkinsID (unique-id) locatorId will be inserted by the
ShibAuthenticationFilterin thepass-core/pass-core-mainproject when the user logs into Pass.Update the user locator ID logic that detects if locator IDs need to be updated. Now only the JHED ID is updated if it is different than what is in Pass.
Consolidated JhuPassUpdater and CoeusPassEntityUtil since JhuPassUpdater was very thin and the logic in CoeusPassEntityUtil is for updating Jhu Pass entities. This simplifies the code base.
Added grant difference logging for init mode so we know the changes that were made on grant so that data verification can be done.
Did some other general cleanup like removing methods in code base used only for testing.