Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JHU Internal API to v3 in the Grant Loader #680

Closed
tsande16 opened this issue Aug 10, 2023 · 3 comments
Closed

Update JHU Internal API to v3 in the Grant Loader #680

tsande16 opened this issue Aug 10, 2023 · 3 comments
Assignees
@tsande16
Milestone
1.1.0 (October)

Comments

@tsande16
Copy link
Contributor

tsande16 commented Aug 10, 2023 •
edited
Loading

The JHU internal API is currently v2 for looking up an EmployeeID using the HopkinsID updating it to v3 may improve performance. Using the v3 API also has more endpoints which can provide more information if needed.

The usage of the directory lookup is here: https://github.com/eclipse-pass/pass-support/blob/b10673ca95ef2e91416350b56845e2a782395359/pass-grant-loader/pass-grant-data/src/main/java/org/eclipse/pass/support/grant/data/DirectoryServiceUtil.java
@tsande16 tsande16 added this to the Post 1.0.0 milestone Aug 10, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Aug 10, 2023
@tsande16 tsande16 mentioned this issue Aug 10, 2023
Closed
@tsande16 tsande16 self-assigned this Aug 10, 2023
@tsande16
Copy link
Contributor Author

Getting a head start on this, requesting access for the V3 client_id and secret.

@tsande16
Copy link
Contributor Author

Will need to add other developers on the team, since they don't support a service account. Please let me know who else should be granted access to the internal JHU API application for our group.

@markpatton

@tsande16 tsande16 moved this from Backlog to In Progress in Eclipse PASS Oct 2, 2023
@tsande16 tsande16 modified the milestones: Post 1.0.0, October launch Oct 2, 2023
@rpoet-jh
Copy link
Contributor

rpoet-jh commented Oct 3, 2023

Because of this PR: eclipse-pass/pass-support#60 , this issue can be deleted.

@tsande16 tsande16 closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Eclipse PASS Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsande16 tsande16

Labels
None yet
Projects
Eclipse PASS
Archived in project
Milestone
1.1.0 (October)
Development

No branches or pull requests
2 participants
@tsande16 @rpoet-jh