Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use org.glassfish.hk2.osgi-resource-locator from latest Orbit #569

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 6, 2024

  • Use version 1.0.3 which is newer than all the current 2.x versions

eclipse-simrel/simrel.build#438

The 2.5.0 versions are all older than the 1.0.3 version:

https://repo1.maven.org/maven2/org/glassfish/hk2/osgi-resource-locator/

- Use version 1.0.3 which is newer than all the current 2.x versions

eclipse-simrel/simrel.build#438
@merks merks force-pushed the pr-hk2.osgi-resource-locator branch from 4c6ef76 to d17d3ff Compare July 6, 2024 12:59
@merks
Copy link
Contributor Author

merks commented Jul 6, 2024

@gnl42 @BeckerFrank @ruspl-afed

Guys, I assume you have no concerns about this trivial change...

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
However having 1.0.3 newer than any 2.x is not so trivial

@merks
Copy link
Contributor Author

merks commented Jul 6, 2024

LGTM However having 1.0.3 newer than any 2.x is not so trivial

I didn't actually test what the build produces, only how the *.target resolves in the IDE. How Tycho does it versus how PDE does it might be two different answers. I shall check now locally. The target might have to specify an exact version...

@merks
Copy link
Contributor Author

merks commented Jul 6, 2024

@ruspl-afed

I tested at locally it has the 1.0.3 version in the repository:

image

So it appears the trivial change has the intended effect. Is there some other concern I've overlooked?

@ruspl-afed
Copy link
Contributor

Is there some other concern I've overlooked?

None from my side. Thank you @merks

@merks
Copy link
Contributor Author

merks commented Jul 6, 2024

Very good. I will given the other folks a bit more time, but I don't think there's anything controversial here. 😀

@merks merks merged commit cebc8f7 into eclipse-mylyn:main Jul 8, 2024
3 checks passed
@merks merks deleted the pr-hk2.osgi-resource-locator branch July 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants