Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate outdated 3rd party content from SimRel #438

Open
22 of 47 tasks
merks opened this issue Jul 2, 2024 · 7 comments
Open
22 of 47 tasks

Eliminate outdated 3rd party content from SimRel #438

merks opened this issue Jul 2, 2024 · 7 comments

Comments

@merks
Copy link
Contributor

merks commented Jul 2, 2024

In order to ensure we can address any problems, e.g., CVEs, that might arise in 3rd party bundles in the future, we need to be prepared to update those dependencies. The following dependencies are not currently part of the restructured Orbit aggregation and need to be investigated to determine where and why these outdated versions are being used:


The above list was produced by adding validation repositories to both validation sets in simrel.aggr

image

and specifying to exclude all IUs available from a validation repository:

image

With this approach, the analysis editors view shows only the subset of 3rd party libraries that do not come from the restructured Orbit aggregation:

image

@HannesWell
Copy link
Contributor

  • org.eclipse.m2e.maven.runtime/3.9.700.20240602-2313

This is produced and actively maintained by m2e:
https://github.com/eclipse-m2e/m2e-core/tree/13c4a91529f9317399bfcb2a84392f1497d71677/org.eclipse.m2e.maven.runtime

  • org.apache.commons.jxpath/1.3.0.v200911051830

In Eclipse-Platform this is used to process XPath expressions in E4 contributions. A while ago I looked into using the XPath supported provided by the JDK but didn't succeed yet. If there are no other users I could try to complete that work so we can get rid of that dependency in platform.

@merks
Copy link
Contributor Author

merks commented Jul 6, 2024

In Eclipse-Platform this is used to process XPath expressions in E4 contributions. A while ago I looked into using the XPath supported provided by the JDK but didn't succeed yet. If there are no other users I could try to complete that work so we can get rid of that dependency in platform.

The problem here (and in a small number of cases) is that the version in the Orbit aggregation is smaller than the older version. In this case 1.3.0 versus 1.3.0.v200911051830.

As I hunt down these various cases, it's increasing frustrating the extent to which folks just keep pointing at older Orbit repositories sometimes for no apparent reason. And even if there is a reason, i.e., something is needed but is missing, that issue is never raised so of course never addressed.

merks added a commit to merks/org.eclipse.mylyn that referenced this issue Jul 6, 2024
- Use version 1.0.3 which is newer than all the current 2.x versions

eclipse-simrel/simrel.build#438
merks added a commit to merks/org.eclipse.mylyn that referenced this issue Jul 6, 2024
- Use version 1.0.3 which is newer than all the current 2.x versions

eclipse-simrel/simrel.build#438
merks added a commit to merks/webservices that referenced this issue Jul 6, 2024
merks added a commit to merks/sourceediting that referenced this issue Jul 6, 2024
merks added a commit to merks/servertools that referenced this issue Jul 6, 2024
merks added a commit to merks/sourceediting that referenced this issue Jul 6, 2024
merks added a commit to merks/pdt that referenced this issue Jul 7, 2024
- The latest version of the bundle is named
org.apache.commons.common-logging so better to avoid using the bundle
name entirely.

eclipse-simrel/simrel.build#438
@ewillink
Copy link
Contributor

ewillink commented Jul 7, 2024

org.apache.commons.jxpath/1.3.0.v200911051830 → org.apache.commons.jxpath/1.3.0
Orbit provides this direct-from-maven version which is used by the Plaform:

https://repo1.maven.org/maven2/commons-jxpath/commons-jxpath/1.3/

Unfortunately Modisco has this feature include from an old Orbit repository

[1.3.0.v200911051830] - org.eclipse.modisco.infrastructure.feature.feature.group /1.5.4.v20240304-1105
https://git.eclipse.org/r/c/modisco/org.eclipse.modisco/+/207294

https://bugs.eclipse.org/bugs/show_bug.cgi?id=583467 raised. It seems that MoDisco should never have redistributed org.apache.commons.jxpath.

I can contribute MoDisco 1.5.5M1 to SimRel and so eliminate the redistributed org.apache.commons.jxpath once Jenkins gets some TLC. So far I have had 3 JustJ jobs fail with read timeout, 2 UI Gateway timeouts and jobs running at half speed.

@merks
Copy link
Contributor Author

merks commented Jul 7, 2024

... once Jenkins gets some TLC. So far I have had 3 JustJ jobs fail with read timeout, 2 UI Gateway timeouts and jobs running at half speed.

Thanks. That's great. Yes, the ci instances seem to be very slow to respond today. I had to be quite patient getting the Orbit milestones built.

nitind pushed a commit to eclipse-webservices/webservices that referenced this issue Jul 7, 2024
nitind pushed a commit to eclipse-sourceediting/sourceediting that referenced this issue Jul 7, 2024
nitind pushed a commit to eclipse-servertools/servertools that referenced this issue Jul 7, 2024
merks added a commit to merks/pdt that referenced this issue Jul 7, 2024
- The latest version of these are named
org.apache.commons.common-io and org.apache.commons.common-logging so
better to avoid using the bundle name entirely.

eclipse-simrel/simrel.build#438
merks added a commit to merks/cdo that referenced this issue Jul 7, 2024
- org.apache.commons.logging -> org.apache.commons.commons-logging

eclipse-simrel/simrel.build#438
merks added a commit to eclipse-mylyn/org.eclipse.mylyn that referenced this issue Jul 8, 2024
- Use version 1.0.3 which is newer than all the current 2.x versions

eclipse-simrel/simrel.build#438
@bhufmann
Copy link
Contributor

bhufmann commented Jul 9, 2024

Please note that the Eclipse EASE project is depending on org.mozilla.javascript/1.7.10.v20190430-1943. Right now the dependency is pulled in from an older orbit version. However, the EASE project is not part of the simrel release. I don't know about the plans of the EASE project for this update. I just wanted to mention it.

https://gitlab.eclipse.org/eclipse/ease/ease/-/blob/main/releng/org.eclipse.ease.releng.target/org.eclipse.ease.releng.target.target?ref_type=heads#L28

@merks
Copy link
Contributor Author

merks commented Jul 10, 2024

I think it's often tricky to find a replacement/updated version in a newer orbit update site because the bundle name has changed. That's the case for libraries that are available as OSGi bundles in Maven Central which are now consumed as-is rather than being rebundled by Orbit. as was done in the past.

Here is a good technique for that. In the Repository Explorer, switch to Export Mode and choose to view java.package capabilities.

image

Search for any package:

image

Double click the package to see the IU details and from that you can see which bundle provides that package:

image

If folks think something is missing, they should ask about it here:

https://github.com/orgs/eclipse-orbit/discussions

merks added a commit to merks/cdo that referenced this issue Jul 13, 2024
- org.apache.commons.logging -> org.apache.commons.commons-logging

eclipse-simrel/simrel.build#438
estepper pushed a commit to eclipse-cdo/cdo that referenced this issue Jul 13, 2024
- org.apache.commons.logging -> org.apache.commons.commons-logging

eclipse-simrel/simrel.build#438
merks added a commit to merks/webservices that referenced this issue Jul 17, 2024
- jakarta.el -> jakarta.el-api
- jakarta.servlet -> jakarta.servlet-api
- jakarta.servlet.jsp -> jakarta.servlet.jsp-api
- javax.mail -> jakarta.mail-api
- javax.xml.rpc -> javax.xml.rpc-api
- javax.xml.soap -> jakarta.xml.soap-api
- javax.wsdl 1.6.3
- javax.jws -> jakarta.jws-api
- jakarta.xml.bind -> jakarta.xml.bind-api
- javax.xml.stream delete
- javax.xml.ws -> jakarta.xml.ws-api
- org.junit4 -> org.junit

eclipse-simrel/simrel.build#438
merks added a commit to merks/sourceediting that referenced this issue Jul 17, 2024
- javax.xml delete
- java_cup-runtime delete - available in org.apache.xalan
- org.apache.bcel delete - not needed

eclipse-simrel/simrel.build#438
merks added a commit to merks/webtools.dali that referenced this issue Jul 17, 2024
- javax.wsdl 1.6.3
- javax.persistence -> jakarta.persistence-api

eclipse-simrel/simrel.build#438
merks added a commit to merks/org.eclipse.rap that referenced this issue Jul 20, 2024
merks added a commit to merks/org.eclipse.rap that referenced this issue Jul 20, 2024
mknauer pushed a commit to eclipse-rap/org.eclipse.rap that referenced this issue Jul 31, 2024
@avandorp
Copy link
Contributor

avandorp commented Aug 7, 2024

SimRel 2024-09 M1 and M2 seem to suffer from incompatible versions of apache commons logging. I've filed bug eclipse-orbit/orbit-simrel#40 . Is this an issue that belongs here (I see some MRs regarding apache commons logging)?

nitind pushed a commit to eclipse-sourceediting/sourceediting that referenced this issue Sep 14, 2024
- javax.xml delete
- java_cup-runtime delete - available in org.apache.xalan
- org.apache.bcel delete - not needed

eclipse-simrel/simrel.build#438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants