Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile and lint verifications before testing #23224

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Oct 31, 2024

What does this PR do?

  • Add 2 steps for quick checking the PR on compiling and linter errors before starting minikube

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#23221

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9
Copy link
Contributor

Looks good to merge as for me

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Workspace PR check has passed with compile and lint verification's added https://github.com/eclipse-che/che/actions/runs/11614307434/job/32342150430

Well done, @musienko-maxim !

@musienko-maxim musienko-maxim merged commit 2d10027 into main Oct 31, 2024
5 checks passed
@musienko-maxim musienko-maxim deleted the add-linter-and-compiling-err-for-github-actions branch October 31, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants