Skip to content

Commit

Permalink
Add compile and lint verifications before testing (#23224)
Browse files Browse the repository at this point in the history
* add compile and lint verifications before testing
  • Loading branch information
musienko-maxim authored Oct 31, 2024
1 parent 51a833a commit 2d10027
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ env:
jobs:
pr-check:
runs-on: ubuntu-22.04

defaults:
run:
working-directory: tests/e2e
steps:
- name: Git checkout
uses: actions/checkout@v2
Expand All @@ -48,6 +50,15 @@ jobs:
with:
node-version: '16'

- name: Check compilation errors
run: |
npm ci
npm run tsc
- name: Check lint errors
run: |
npm run lint
- name: Start minikube
id: run-minikube
uses: che-incubator/setup-minikube-action@next
Expand Down Expand Up @@ -92,8 +103,6 @@ jobs:
- name: Run Empty Workspace API test
run: |
cd tests/e2e
npm ci
export TS_PLATFORM=kubernetes &&
export TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL=kubectl &&
export TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=false &&
Expand All @@ -109,7 +118,6 @@ jobs:
run: |
# for saving disk space we can remove the assembly folder because it is legacy code
rm -rf assembly
cd tests/e2e
docker build -t quay.io/eclipse/che-e2e:"${{ env.pr_number }}" -f build/dockerfiles/Dockerfile .
# we have already ran API test, built test image and do not need e2e test-code, remove for saving disk space
Expand Down

0 comments on commit 2d10027

Please sign in to comment.