Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to configure 2 gitlab providers simultaneously #731

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Oct 23, 2024

What does this PR do?

Allow to configure 2 gitlab providers simultaneously

Screenshot/screencast of this PR

screenshot-cluster-admin-che-dashboard-local-server_apps_rosa_oaky8-tf8zx-r5p_asdn_p3_openshiftapps_com-2024_10_23-11_53_49
screenshot-cluster-admin-che-dashboard-local-server_apps_rosa_oaky8-tf8zx-r5p_asdn_p3_openshiftapps_com-2024_10_23-11_54_23

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7142

How to test this PR?

  1. Deploy che-server image: quay.io/eclipse/che-server:pr-731
  2. Deploy che-operator image: quay.io/ivinokur/che-operator:next
  3. Deploy che-dashboard image: quay.io/eclipse/che-dashboard:pr-1237
  4. Configure oauth for two gitlab instances, add a random suffix for the second oauth secret name.
  5. Start a workspace from each gitlab repository with a devfille.
  6. See: personal access token is generated for both gitlab instances.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

With this feature it is possible to configure two Gitlab oauth providers simultaneously.

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Copy link
Contributor

tolusha commented Oct 25, 2024

Only the first GitLab provider can be revoked.

screenshot-eclipse-che_apps_ci-ln-27mym1b-76ef8_aws-2_ci_openshift_org-2024_10_25-12_37_37

@artaleks9 artaleks9 self-requested a review October 25, 2024 13:25
@vinokurig
Copy link
Contributor Author

@tolusha

Only the first GitLab provider can be revoked.

Should be fixed by the dashboard pull request fixup.

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with gitlab server and GitLab.com using

quay.io/eclipse/che-server:pr-731
quay.io/ivinokur/che-operator:next
quay.io/eclipse/che-dashboard:pr-1237

The functionality works properly.


Verification with two gitlab servers is still in progress.

@artaleks9
Copy link
Contributor

artaleks9 commented Oct 28, 2024

Verification with two gitlab servers is finished.
The functionality also works properly.

See screenshots:
pr73-git-sevices
pr731-pat-dashboard

Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 1b8a190 into main Oct 28, 2024
28 checks passed
@vinokurig vinokurig deleted the CRW-7142 branch October 28, 2024 12:53
@devstudio-release
Copy link

Build 3.18 :: server_3.x/367: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: server_3.x/367: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7929 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7991: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65455836 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants