-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to configure 2 gitlab providers simultaneously #1237
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1237 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1237", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 89.83% 89.90% +0.07%
==========================================
Files 445 445
Lines 45991 46043 +52
Branches 3084 3093 +9
==========================================
+ Hits 41316 41396 +80
+ Misses 4640 4613 -27
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1237 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1237", name: che-dashboard}]}}]" |
Build 3.18 :: dashboard_3.x/579: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7928: Console, Changes, Git Data |
What does this PR do?
Allow to configure 2 gitlab providers simultaneously
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7142
Is it tested? How?
see eclipse-che/che-server#731
Release Notes
Docs PR