Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to configure 2 gitlab providers simultaneously #1237

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Allow to configure 2 gitlab providers simultaneously

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7142

Is it tested? How?

see eclipse-che/che-server#731

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Oct 23, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1237

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1237", name: che-dashboard}]}}]"

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (899937c) to head (5e27b0b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   89.83%   89.90%   +0.07%     
==========================================
  Files         445      445              
  Lines       45991    46043      +52     
  Branches     3084     3093       +9     
==========================================
+ Hits        41316    41396      +80     
+ Misses       4640     4613      -27     
+ Partials       35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 25, 2024
Copy link

openshift-ci bot commented Oct 25, 2024

New changes are detected. LGTM label has been removed.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1237

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1237", name: che-dashboard}]}}]"

@vinokurig vinokurig merged commit 8319b81 into main Oct 28, 2024
20 checks passed
@vinokurig vinokurig deleted the CRW-7142 branch October 28, 2024 12:53
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/579: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants