Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for git remotes #1217

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Check for git remotes #1217

merged 1 commit into from
Oct 11, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Oct 10, 2024

What does this PR do?

This PR fixes the condition when the token refresh request is sent.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7476

Is it tested? How?

  1. Deploy Eclipse Che;
  2. Use this command to update the Dashboard deployment:
    kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1217", name: che-dashboard}]}}]"
  3. Create a workspace using this devfile: https://github.com/jbossas/eap-devfile-examples/blob/eap-8.0.x/devfile.yaml

@akurinnoy akurinnoy self-assigned this Oct 10, 2024
@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2024

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy mentioned this pull request Oct 10, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1217

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1217", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (23f9a7c) to head (842c1c2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
- Coverage   89.79%   89.74%   -0.06%     
==========================================
  Files         443      443              
  Lines       45793    45793              
  Branches     3051     3056       +5     
==========================================
- Hits        41120    41097      -23     
- Misses       4635     4658      +23     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akurinnoy akurinnoy merged commit 1e79b3d into main Oct 11, 2024
19 of 20 checks passed
@akurinnoy akurinnoy deleted the check-for-git-remotes branch October 11, 2024 14:00
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/566: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

olexii4 pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants