-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for git remotes #1218
Check for git remotes #1218
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1218 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1218", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, I need help from to see Dev Spaces samples and so be able to create JBoss EAP 8.0 workspace when test cherry-pick in 7.92 #1218 using Dev Spaces 3.17.0 + quay.io/eclipse/che-dashboard:pr-1218. Also I haven't reproduced the issue on the Dev Spaces 3.17.0.RC-devspaces-operator-bundle-container-3.17-32 WITHOUT quay.io/eclipse/che-dashboard:pr-1218 using factory URL https://github.com/jbossas/eap-devfile-examples/blob/eap-8.0.x/devfile.yaml you mentioned in PR into the main #1217 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha prepared Eclipse Che Dashboard image built from this PR with Dev Spaces 3.17 samples.
I have tested it with Dev Spaces 3.17.0.RC, and didn't encounter warning popup when started "JBoss EAP 8.0" workspace:
scrnli_Sy8YCpFPNS1802.webm
Good job, @akurinnoy !
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: dashboard_3.17/9: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/40: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.17/32: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.17/42: dashboard : 3.17 :: Build 64995841 : quay.io/devspaces/dashboard-rhel8:3.17-14 |
Build 3.17 :: update-digests_3.17/83: Console, Changes, Git Data |
Build 3.17 :: dashboard_3.17/9: Upstream sync done; /DS_CI/sync-to-downstream_3.17/40 triggered |
Build 3.17 :: operator-bundle_3.17/14: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/41: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.17/33: Console, Changes, Git Data |
Build 3.17 :: copyIIBsToQuay/2847: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/41: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.17/43 triggered; /job/DS_CI/job/dsc_3.17 triggered; |
Build 3.17 :: operator-bundle_3.17/14: Upstream sync done; /DS_CI/sync-to-downstream_3.17/41 triggered |
Build 3.17 :: dsc_3.17/14: Console, Changes, Git Data |
Build 3.17 :: update-digests_3.17/83: Detected new images: rebuild operator-bundle |
Build 3.17 :: dsc_3.17/14: 3.17.0-CI |
What does this PR do?
cherry-pick of #1217