Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for git remotes #1218

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Check for git remotes #1218

merged 1 commit into from
Oct 11, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

cherry-pick of #1217

@che-bot
Copy link
Contributor

che-bot commented Oct 10, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1218

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1218", name: che-dashboard}]}}]"

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmytro-ndp
Copy link
Contributor

Actually, I need help from to see Dev Spaces samples and so be able to create JBoss EAP 8.0 workspace when test cherry-pick in 7.92 #1218 using Dev Spaces 3.17.0 + quay.io/eclipse/che-dashboard:pr-1218.
Screenshot from 2024-10-10 20-07-19

Also I haven't reproduced the issue on the Dev Spaces 3.17.0.RC-devspaces-operator-bundle-container-3.17-32 WITHOUT quay.io/eclipse/che-dashboard:pr-1218 using factory URL https://github.com/jbossas/eap-devfile-examples/blob/eap-8.0.x/devfile.yaml you mentioned in PR into the main #1217
Screenshot from 2024-10-10 20-30-02

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha prepared Eclipse Che Dashboard image built from this PR with Dev Spaces 3.17 samples.
I have tested it with Dev Spaces 3.17.0.RC, and didn't encounter warning popup when started "JBoss EAP 8.0" workspace:
scrnli_Sy8YCpFPNS1802.webm

Good job, @akurinnoy !

Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmytro-ndp dmytro-ndp merged commit 2e98226 into 7.92.x Oct 11, 2024
13 checks passed
@dmytro-ndp dmytro-ndp deleted the 7.92.x-check-for-git-remotes branch October 11, 2024 13:47
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.17/9: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.17/83: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: dashboard_3.17/9: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.17/40 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2847: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.17/41: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.17/43 triggered; /job/DS_CI/job/dsc_3.17 triggered;

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.17/14: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.17/41 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.17/14: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.17/83: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.17/14 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.17/14: SUCCESS

3.17.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants