Refactored ListUnitsRequest and ListUnitFilesRequest #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @trev-allison03 |
engelmi
force-pushed
the
refactor-list-units-and-list-unit-files
branch
2 times, most recently
from
e549c2a
to
151a391
Compare
Relates to: eclipse-bluechi#889 The structs and functions used for ListUnits and ListUnitFiles are identical for the most part. In order to reduce code duplication, the implementation for both have been combined into a single struct with unified functions. This should also allow for additional, similar features in the future. Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
In the new build-base image, a newer clang version with an updated set of checks is detecting issues. The issues - bugprone-multi-level-implicit-pointerconversion - cppcoreguidelines-macro-to-enum have been added to the ignore list while others have been fixed. Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
refactor-list-units-and-list-unit-files
branch
from
151a391
to
6e23e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #889
The structs and functions used for ListUnits and ListUnitFiles are identical for the most part. In order to reduce code duplication, the implementation for both have been combined into a single struct with unified functions. This should also allow for additional, similar features in the future.