Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add ListUnitFiles API #889

Closed
6 tasks done
engelmi opened this issue Apr 22, 2024 · 1 comment · Fixed by #915
Closed
6 tasks done

RFE: Add ListUnitFiles API #889

engelmi opened this issue Apr 22, 2024 · 1 comment · Fixed by #915
Assignees
Labels
backlog This is next up in priority enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@engelmi
Copy link
Member

engelmi commented Apr 22, 2024

Please describe what you would like to see

This RFE resulted from #887.

Based on how systemctl list-units works, it is not possible to query services that aren't reference in any way (e.g. via RequiredBy = multi-user.target) or are active/failed.
systemd's ListUnitFiles API can be used to address this issue and return a list of files. So in order to enable a more complete view of available services, a new API for listing unit files should be added to BlueChi.

Please describe the solution you'd like

  • bluechi-controller: Add new API method on public DBus and delegate to bluechi-agent
  • bluechi-agent: Add new API on internal DBus and delegate to systemd bus
  • bluechictl: Add new command list-unit-files [file-name-pattern] where pattern can be used to filter by file name glob (similar to bluechictls list-units)
  • Implement integration tests
  • Extend documentation (man pages, examples, etc.)
  • Refactor ListUnitsRequest and ListUnitFilesRequest by unifying these structs and the respective functions (see this comment) (Refactored ListUnitsRequest and ListUnitFilesRequest #923)

Please describe your use case

For example, systemd services generated from quadlet files are not visible via ListUnits method (based on how systemctl list-units works). Using list-unit-files such service files can be queried as well.

@engelmi engelmi added enhancement New feature or request help wanted Extra attention is needed backlog This is next up in priority labels Apr 22, 2024
@engelmi engelmi added this to the v0.9 milestone Apr 22, 2024
@trev-allison03
Copy link
Contributor

Assign to me

trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 23, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 23, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 23, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 23, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 24, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 24, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 25, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 25, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 25, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 30, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Jul 31, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
trev-allison03 pushed a commit to trev-allison03/bluechi that referenced this issue Aug 6, 2024
mwperina pushed a commit to trev-allison03/bluechi that referenced this issue Aug 7, 2024
mwperina pushed a commit to trev-allison03/bluechi that referenced this issue Aug 7, 2024
mwperina pushed a commit to trev-allison03/bluechi that referenced this issue Aug 7, 2024
mwperina pushed a commit to trev-allison03/bluechi that referenced this issue Aug 7, 2024
mwperina pushed a commit to trev-allison03/bluechi that referenced this issue Aug 7, 2024
engelmi pushed a commit that referenced this issue Aug 7, 2024
engelmi pushed a commit that referenced this issue Aug 7, 2024
engelmi pushed a commit that referenced this issue Aug 7, 2024
engelmi pushed a commit that referenced this issue Aug 7, 2024
engelmi pushed a commit that referenced this issue Aug 7, 2024
@engelmi engelmi reopened this Aug 7, 2024
engelmi added a commit to engelmi/bluechi that referenced this issue Aug 9, 2024
Relates to: eclipse-bluechi#889

The structs and functions used for ListUnits and ListUnitFiles are
identical for the most part. In order to reduce code duplication, the
implementation for both have been combined into a single struct with
unified functions. This should also allow for additional, similar features
in the future.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit to engelmi/bluechi that referenced this issue Aug 9, 2024
Relates to: eclipse-bluechi#889

The structs and functions used for ListUnits and ListUnitFiles are
identical for the most part. In order to reduce code duplication, the
implementation for both have been combined into a single struct with
unified functions. This should also allow for additional, similar features
in the future.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit to engelmi/bluechi that referenced this issue Aug 9, 2024
Relates to: eclipse-bluechi#889

The structs and functions used for ListUnits and ListUnitFiles are
identical for the most part. In order to reduce code duplication, the
implementation for both have been combined into a single struct with
unified functions. This should also allow for additional, similar features
in the future.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Aug 12, 2024
Relates to: #889

The structs and functions used for ListUnits and ListUnitFiles are
identical for the most part. In order to reduce code duplication, the
implementation for both have been combined into a single struct with
unified functions. This should also allow for additional, similar features
in the future.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi closed this as completed Aug 13, 2024
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 11, 2024
Relates to: eclipse-bluechi#889

Added ListUnitFiles to the API description for the readthedocs and
in the API specification for the internal Agent interface.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 11, 2024
Relates to: eclipse-bluechi#889

Added ListUnitFiles to the API description for the readthedocs and
in the API specification for the internal Agent interface.

Signed-off-by: Michael Engel <[email protected]>
mwperina pushed a commit to engelmi/bluechi that referenced this issue Sep 13, 2024
Relates to: eclipse-bluechi#889

Added ListUnitFiles to the API description for the readthedocs and
in the API specification for the internal Agent interface.

Signed-off-by: Michael Engel <[email protected]>
mwperina pushed a commit that referenced this issue Sep 13, 2024
Relates to: #889

Added ListUnitFiles to the API description for the readthedocs and
in the API specification for the internal Agent interface.

Signed-off-by: Michael Engel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This is next up in priority enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants