Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN-500 eggd_generate_variant_workbook v2.9.0 #196

Draft
wants to merge 103 commits into
base: master
Choose a base branch
from

Conversation

Aisha-D
Copy link
Contributor

@Aisha-D Aisha-D commented May 2, 2024

Changes are mainly to keep uranus-centric features currently provided from the handler app to be presented in the workbook. The changes include:

Testing page: https://cuhbioinformatics.atlassian.net/wiki/spaces/DV/pages/3193929758/eggd+generate+variant+workbook+-+v2.9.0


This change is Reviewable

@pep8speaks
Copy link

pep8speaks commented May 2, 2024

Hello @Aisha-D! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 221:80: E501 line too long (83 > 79 characters)
Line 319:13: E128 continuation line under-indented for visual indent
Line 320:13: E124 closing bracket does not match visual indentation
Line 325:13: E124 closing bracket does not match visual indentation

Line 212:41: E251 unexpected spaces around keyword / parameter equals
Line 212:43: E251 unexpected spaces around keyword / parameter equals
Line 636:73: E251 unexpected spaces around keyword / parameter equals
Line 636:75: E251 unexpected spaces around keyword / parameter equals
Line 691:1: E302 expected 2 blank lines, found 1
Line 699:80: E501 line too long (89 > 79 characters)
Line 723:80: E501 line too long (89 > 79 characters)
Line 736:27: E222 multiple spaces after operator
Line 743:35: E231 missing whitespace after ','
Line 745:80: E501 line too long (102 > 79 characters)

Line 190:5: E303 too many blank lines (2)
Line 191:13: E117 over-indented
Line 224:80: E501 line too long (80 > 79 characters)
Line 264:80: E501 line too long (88 > 79 characters)
Line 289:80: E501 line too long (81 > 79 characters)
Line 1492:26: E203 whitespace before ':'
Line 1846:5: E303 too many blank lines (2)

Line 146:80: E501 line too long (84 > 79 characters)

Line 428:37: E225 missing whitespace around operator
Line 577:5: E303 too many blank lines (2)
Line 617:5: E303 too many blank lines (2)
Line 676:5: E303 too many blank lines (2)
Line 797:5: E303 too many blank lines (2)
Line 953:5: E303 too many blank lines (2)
Line 966:5: E303 too many blank lines (2)
Line 990:5: E303 too many blank lines (2)

Comment last updated at 2024-08-30 15:35:46 UTC

@Aisha-D Aisha-D changed the title IN-500 eggd generate variant workbook v 2 9 0 IN-500 eggd_generate_variant_workbook v2.9.0 May 2, 2024
@Aisha-D Aisha-D marked this pull request as draft May 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants